git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add gitattributes file making whitespace checking pickier
Date: Sat, 9 Feb 2008 18:39:48 -0500	[thread overview]
Message-ID: <20080209233948.GC20501@fieldses.org> (raw)
In-Reply-To: <200802092122.01656.jnareb@gmail.com>

On Sat, Feb 09, 2008 at 09:22:00PM +0100, Jakub Narebski wrote:
> J. Bruce Fields wrote:
> > On Sat, Feb 09, 2008 at 11:36:31AM -0800, Jakub Narebski wrote:
> > > "J. Bruce Fields" <bfields@fieldses.org> writes:
> > > 
> > > >  gitweb/gitweb.perl                                  |  566 ++--
> > > >  index-pack.c                                        |   30 
> > > 
> > > gitweb (at my insistence) uses tabs for indent, but spaces for align,
> > > so that the layout is [roughly] preserved independently of the tab
> > > size. IMHO it is superior style, but much harder to check
> > > algorithmically (although I send some sketch of idea how to check that
> > > at least for aligned commands). That is why there is such a big change.
> > > 
> > > I'd rather have real bugfixes, real documentation improvements, new
> > > features instead of such bikeshedding.  If someone is making a change
> > > somewhere, he/she can fix the whitespace in the neighbourhood.
> > 
> > I agree completely.  Did I suggest otherwise?
> 
> Ah, sorry, I have misunderstood.
> 
> This is an informational piece, then, isn't it?

Yeah, I was generating the diff just as a way to get an idea which paths
which policies should apply to.

That still doesn't rise much above bikeshedding, but it's not quite as
bad as actually trying to apply such a diff...

--b.

  reply	other threads:[~2008-02-09 23:40 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-09 16:22 [PATCH] Add gitattributes file making whitespace checking pickier J. Bruce Fields
2008-02-09 17:56 ` Daniel Barkalow
2008-02-09 18:50   ` J. Bruce Fields
2008-02-09 19:05     ` J. Bruce Fields
2008-02-09 19:36       ` Jakub Narebski
2008-02-09 20:04         ` J. Bruce Fields
2008-02-09 20:22           ` Jakub Narebski
2008-02-09 23:39             ` J. Bruce Fields [this message]
2008-02-09 20:57     ` Junio C Hamano
2008-02-09 23:36       ` J. Bruce Fields
2008-02-09 23:45       ` Jakub Narebski
2008-02-10  4:01         ` Junio C Hamano
2008-02-10 11:31           ` Jakub Narebski
2008-02-10 21:52             ` Junio C Hamano
2008-02-10 10:52       ` Junio C Hamano
2008-02-10 18:56         ` J. Bruce Fields
2008-02-10 20:22         ` Daniel Barkalow
2008-02-10 21:47           ` Junio C Hamano
2008-02-10 22:34             ` Daniel Barkalow
2008-02-11  3:34               ` Junio C Hamano
2008-02-12  7:43         ` Brian Downing
2008-02-12 21:42           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080209233948.GC20501@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).