From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Miklos Vajna <vmiklos@frugalware.org>,
Matthieu Moy <Matthieu.Moy@imag.fr>,
Francis Moreau <francis.moro@gmail.com>,
git@vger.kernel.org
Subject: Re: [RFC/PATCH] Implement git-cp.
Date: Mon, 11 Feb 2008 02:30:06 +0100 [thread overview]
Message-ID: <200802110230.06808.jnareb@gmail.com> (raw)
In-Reply-To: <7vzlu9uu7c.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > If you touch builtin-mv.c already, why not just move cmd_cp() in there?
> > It's not like it would be the first cmd_*() function living in the same
> > file as other cmd_*() functions.
>
> Why do we even want "git-cp", especially when git-mv and git-rm
> are already pretty much redundant commands?
git-rm is not redundant: without it how we could easily un-add
a file (without resorting to porcelain or tricks). I think it
is also safer that ordinary rm (check for being up-to-date, i.e.
for modified files).
The above also reflects git-mv, as half of it is git-rm (although
without some issues). Also git-mv could skip over non git-controlled
files.
> Especially, why do we even encourage copy-and-paste?
But git-cp would be IMHO a convenience only. The half of pros for
git-mv applies to this too; unfortunately the second part of pros
for git-mv does not apply for git-cp.
Would git-cp encourage copy'n'paste programming? I'm not sure...
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2008-02-11 1:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-03 18:23 What about git cp ? Francis Moreau
2008-02-03 18:46 ` Matthieu Moy
2008-02-03 19:07 ` Jakub Narebski
2008-02-10 1:12 ` [RFC/PATCH] Implement git-cp Miklos Vajna
2008-02-10 1:26 ` Johannes Schindelin
2008-02-10 7:49 ` Junio C Hamano
2008-02-10 12:33 ` Johannes Schindelin
2008-02-10 12:42 ` Miklos Vajna
2008-02-10 13:29 ` Robin Rosenberg
2008-02-11 1:30 ` Jakub Narebski [this message]
2008-02-11 10:18 ` Matthieu Moy
2008-02-11 13:43 ` Miklos Vajna
2008-02-10 18:24 ` [PATCH] " Miklos Vajna
2008-02-03 18:55 ` What about git cp ? Remi Vanicat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802110230.06808.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=Matthieu.Moy@imag.fr \
--cc=francis.moro@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).