From: Christian Couder <chriscool@tuxfamily.org>
To: Junio Hamano <junkio@cox.net>,
Johannes Sixt <j.sixt@viscovery.net>,
Pierre Habouzit <madcoder@debian.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: git@vger.kernel.org
Subject: [PATCH] config: deprecate using "" as boolean value false.
Date: Mon, 11 Feb 2008 08:22:16 +0100 [thread overview]
Message-ID: <20080211082216.e9212310.chriscool@tuxfamily.org> (raw)
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
config.c | 13 ++++++++++++-
1 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/config.c b/config.c
index 526a3f4..b5f1a11 100644
--- a/config.c
+++ b/config.c
@@ -300,8 +300,19 @@ int git_config_bool(const char *name, const char *value)
{
if (!value)
return 1;
- if (!*value)
+ if (!*value) {
+ fprintf(stderr,
+ "Warning: using an empty value for boolean config "
+ "variables is deprecated.\n"
+ "An empty value currently means 'false' as a "
+ "boolean, but may very well means 'true' in the "
+ "future!\n"
+ "Please consider using a 'false' value explicitely "
+ "for variable '%s', so that your config is future "
+ "proof. You can do that using:\n"
+ "\tgit config %s false\n", name, name);
return 0;
+ }
if (!strcasecmp(value, "true") || !strcasecmp(value, "yes"))
return 1;
if (!strcasecmp(value, "false") || !strcasecmp(value, "no"))
--
1.5.4.20.gc135a-dirty
next reply other threads:[~2008-02-11 7:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-11 7:22 Christian Couder [this message]
2008-02-11 8:21 ` [PATCH] config: deprecate using "" as boolean value false Junio C Hamano
2008-02-11 8:46 ` Junio C Hamano
2008-02-11 9:22 ` [PATCH] teach config parsers to diagnose missing values Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080211082216.e9212310.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=junkio@cox.net \
--cc=madcoder@debian.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).