From: "H.Merijn Brand" <h.m.brand@xs4all.nl>
To: Andreas Ericsson <ae@op5.se>
Cc: git@vger.kernel.org
Subject: Re: read_branches_file ()
Date: Mon, 11 Feb 2008 11:17:41 +0100 [thread overview]
Message-ID: <20080211111741.2269f89b@pc09.procura.nl> (raw)
In-Reply-To: <47B01CD4.4040004@op5.se>
On Mon, 11 Feb 2008 11:00:52 +0100, Andreas Ericsson <ae@op5.se> wrote:
> H.Merijn Brand wrote:
> > - if (!f)
> > + if (stat (gp, &st_buf) || S_ISDIR (st_buf.st_mode))
>
> Shouldn't this be
> if (stat(gp, &st_buf) || !S_ISREG(st_buf.st_mode))
Yes, see several follow-ups in this thread.
> ?
>
> Otherwise, you might end up opening a FIFO, a socket or a
> block/char special, which is obviously undesired.
At the moment of the patch I was unsure if these were supported :)
At least FIFO's and character devices are less error-prone than DIR's
--
H.Merijn Brand Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using & porting perl 5.6.2, 5.8.x, 5.10.x on HP-UX 10.20, 11.00, 11.11,
& 11.23, SuSE 10.1 & 10.2, AIX 5.2, and Cygwin. http://qa.perl.org
http://mirrors.develooper.com/hpux/ http://www.test-smoke.org
http://www.goldmark.org/jeff/stupid-disclaimers/
next prev parent reply other threads:[~2008-02-11 10:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-08 15:50 read_branches_file () H.Merijn Brand
2008-02-08 16:03 ` H.Merijn Brand
2008-02-08 16:22 ` Johannes Schindelin
2008-02-08 16:49 ` H.Merijn Brand
2008-02-11 10:00 ` Andreas Ericsson
2008-02-11 10:17 ` H.Merijn Brand [this message]
2008-02-08 17:18 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080211111741.2269f89b@pc09.procura.nl \
--to=h.m.brand@xs4all.nl \
--cc=ae@op5.se \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).