From: "Shawn O. Pearce" <spearce@spearce.org>
To: Seth Falcon <seth@userprimary.net>
Cc: jaysoffian@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH] git-gui: support Git Gui.app under OS X 10.5
Date: Tue, 12 Feb 2008 02:33:06 -0500 [thread overview]
Message-ID: <20080212073306.GA24004@spearce.org> (raw)
In-Reply-To: <m2d4r30yjf.fsf@userprimary.net>
Seth Falcon <seth@userprimary.net> wrote:
> jaysoffian@gmail.com writes:
> > The Tk Framework moved its location in 10.5 compared to 10.4
> >
> > Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
> > ---
> > Argh. Third time's a charm? Sorry, forgot to add my change before
> > amending and resending.
>
> I applied this and things work much better, thanks!
> Tested-by: Seth Falcon <seth@userprimary.net>
Thanks guys. This is now in maint and master. Its going to
be part of git-gui 0.9.3, whenever that happens.
> One thing. When I quit git gui I see the following on the terminal:
>
> TkMacOSXDoHLEvent failed : cppe 1 ,kHighLevelEvent 61657674 0000 tvea,-1708
Yea, I see some random errors from git-gui when I use an option menu.
I think there's something buggy with Tk on Aqua. Maybe we should
report these to the Tk Aqua folks, especially if we could distill
the issue down to a really short Tk script.
--
Shawn.
next prev parent reply other threads:[~2008-02-12 7:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 0:17 [PATCH] git-gui: support Git Gui.app under OS X 10.5 jaysoffian
2008-02-12 1:11 ` Seth Falcon
2008-02-12 7:33 ` Shawn O. Pearce [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-02-11 19:47 jaysoffian+git
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080212073306.GA24004@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=jaysoffian@gmail.com \
--cc=seth@userprimary.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).