From: "Shawn O. Pearce" <spearce@spearce.org>
To: Andreas Ericsson <ae@op5.se>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>, Nicolas Pitre <nico@cam.org>
Subject: Re: [PATCH] pack-objects: Add runtime detection of online CPU's
Date: Tue, 12 Feb 2008 03:27:34 -0500 [thread overview]
Message-ID: <20080212082734.GC24004@spearce.org> (raw)
In-Reply-To: <47B156CD.1010209@op5.se>
Andreas Ericsson <ae@op5.se> wrote:
> diff --git a/thread-utils.h b/thread-utils.h
> new file mode 100644
> index 0000000..53754b3
> --- /dev/null
> +++ b/thread-utils.h
> @@ -0,0 +1,19 @@
> +#ifndef THREAD_COMPAT_H
> +#define THREAD_COMPAT_H
> +
> +#include "cache.h"
> +
> +#ifdef THREADED_DELTA_SEARCH
> +#include <pthread.h>
> +# ifdef _WIN32
> +# define WIN32_LEAN_AND_MEAN
> +# include <windows.h>
> +# endif
> +# if defined(hpux) || defined(__hpux) || defined(_hpux)
> +# include <sys/pstat.h>
> +# endif
> +#endif
Do we have to expose this mess of namespaces to those who include
thread-utils.h? Seems like we don't, as online_cpus has a pretty
simple definition:
> +
> +extern int online_cpus(void);
> +
> +#endif /* THREAD_COMPAT_H */
> --
> 1.5.4.rc5.11.g0eab8
--
Shawn.
next prev parent reply other threads:[~2008-02-12 8:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 8:20 [PATCH] pack-objects: Add runtime detection of online CPU's Andreas Ericsson
2008-02-12 8:27 ` Shawn O. Pearce [this message]
2008-02-12 8:49 ` Johannes Sixt
2008-02-12 11:18 ` Bert Wesarg
2008-02-12 12:21 ` Andreas Ericsson
2008-02-12 14:52 ` Michael Hendricks
2008-02-12 15:44 ` Brandon Casey
2008-02-23 2:11 ` Brandon Casey
2008-02-23 8:18 ` Andreas Ericsson
[not found] ` <1203732369-30314-1-git-send-email-casey@nrlssc.navy.mil>
2008-02-23 2:12 ` [PATCH] pack-objects: Print a message describing the number of threads for packing Brandon Casey
2008-02-26 7:49 ` Jeff King
2008-02-26 8:00 ` Junio C Hamano
2008-02-26 8:06 ` Jeff King
2008-02-26 9:19 ` Junio C Hamano
2008-02-26 9:33 ` Jeff King
2008-02-26 9:40 ` Andreas Ericsson
2008-02-26 15:53 ` Brandon Casey
2008-02-26 17:05 ` Nicolas Pitre
2008-02-26 21:25 ` Jeff King
2008-02-26 21:21 ` Jeff King
2008-02-26 22:50 ` Brandon Casey
2008-02-26 23:04 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080212082734.GC24004@spearce.org \
--to=spearce@spearce.org \
--cc=ae@op5.se \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).