From: Jakub Narebski <jnareb@gmail.com>
To: Wincent Colaiuta <win@wincent.com>
Cc: Git Mailing List <git@vger.kernel.org>, Petr Baudis <pasky@suse.cz>
Subject: Re: gitweb bug: broken "next" and other links
Date: Tue, 12 Feb 2008 12:48:48 +0100 [thread overview]
Message-ID: <200802121248.49002.jnareb@gmail.com> (raw)
In-Reply-To: <200802121239.06287.jnareb@gmail.com>
Jakub Narebski wrote:
> Actually the error is there even without using 'pathinfo' feature,
> namely if you use pathinfo to provide project, for example:
> http://www.example.com/w/project.git?a=shortlog
> then 'next' link on the page lacks project (instead of having
> dereferenced anonymous array reference, i.e. ARRAY(sth)), like below
> http://www.example.com/w/?a=shortlog;pg=1
Errr... what I forgot to write here is that I have checked that
the patch send (the first version) fixes this bug, as checked
"by hand", i.e. by examining gitweb running as Apache CGI module.
> But I could not come up with automated test which would _fail_
> on this error. So please check, and reply if this patch helps.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2008-02-12 11:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-11 12:51 gitweb bug: broken "next" and other links Wincent Colaiuta
2008-02-11 13:02 ` Jakub Narebski
2008-02-11 13:33 ` Wincent Colaiuta
2008-02-11 15:30 ` Jakub Narebski
2008-02-12 11:39 ` Jakub Narebski
2008-02-12 11:48 ` Jakub Narebski [this message]
2008-02-12 12:24 ` Wincent Colaiuta
2008-02-12 13:10 ` Jakub Narebski
2008-02-12 13:34 ` Wincent Colaiuta
2008-02-15 21:16 ` Jakub Narebski
2008-02-17 10:51 ` Wincent Colaiuta
2008-02-17 11:05 ` Junio C Hamano
2008-02-18 23:32 ` Jakub Narebski
2008-02-18 23:56 ` Junio C Hamano
2008-02-19 0:23 ` Jakub Narebski
2008-02-19 0:23 ` Wincent Colaiuta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802121248.49002.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=pasky@suse.cz \
--cc=win@wincent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).