From: Jakub Narebski <jnareb@gmail.com>
To: Wincent Colaiuta <win@wincent.com>
Cc: Git Mailing List <git@vger.kernel.org>, Petr Baudis <pasky@suse.cz>
Subject: Re: gitweb bug: broken "next" and other links
Date: Tue, 12 Feb 2008 14:10:57 +0100 [thread overview]
Message-ID: <200802121410.58208.jnareb@gmail.com> (raw)
In-Reply-To: <E16BED2E-C146-44D8-BD90-ECF0DF89CA35@wincent.com>
Dnia wtorek 12. lutego 2008 13:24, Wincent Colaiuta napisał:
> El 11/2/2008, a las 16:30, Jakub Narebski escribió:
>>
>> I'm sorry. You are right. I haven't seen breakage because it shows
>> only when you use 'pathinfo' feature and pathinfo URLs.
>>
>> Below there is a fix for that; actully only second part mentioned
>> (and first in patch) is needed, i.e. moving setting $params{'project'}
>> before dealing with -replay is needed I think to fix this bug.
>>
>> Could you test it please?
>
> Your patch fixes the "next" links in the shortlog and log views.
>
> It doesn't fix the broken "raw" links in the commitdiff view. I'm
> still seeing links like:
>
> http://example.com/ARRAY(0x8c97f64)?a=commitdiff_plain;h=f29d56269a1c3bd4a970897397470f41553a64f9
Could yu please give an URL for the page containing broken
link, relevant parts of gitweb configuration (gitweb_config.perl),
and gitweb parts of repository configuration, if there are any?
This would help in reproducing this bug, and correcting it.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2008-02-12 13:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-11 12:51 gitweb bug: broken "next" and other links Wincent Colaiuta
2008-02-11 13:02 ` Jakub Narebski
2008-02-11 13:33 ` Wincent Colaiuta
2008-02-11 15:30 ` Jakub Narebski
2008-02-12 11:39 ` Jakub Narebski
2008-02-12 11:48 ` Jakub Narebski
2008-02-12 12:24 ` Wincent Colaiuta
2008-02-12 13:10 ` Jakub Narebski [this message]
2008-02-12 13:34 ` Wincent Colaiuta
2008-02-15 21:16 ` Jakub Narebski
2008-02-17 10:51 ` Wincent Colaiuta
2008-02-17 11:05 ` Junio C Hamano
2008-02-18 23:32 ` Jakub Narebski
2008-02-18 23:56 ` Junio C Hamano
2008-02-19 0:23 ` Jakub Narebski
2008-02-19 0:23 ` Wincent Colaiuta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802121410.58208.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=pasky@suse.cz \
--cc=win@wincent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).