From: Alex Riesen <raa.lkml@gmail.com>
To: Frans Pop <elendil@planet.nl>
Cc: git@vger.kernel.org, Junio C Hamano <junkio@cox.net>,
Christian Couder <chriscool@tuxfamily.org>
Subject: [PATCH] Fix shell quoting in git-bisect
Date: Tue, 12 Feb 2008 21:06:50 +0100 [thread overview]
Message-ID: <20080212200650.GA15258@steel.home> (raw)
In-Reply-To: <200802122023.28879.elendil@planet.nl>
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
Frans Pop, Tue, Feb 12, 2008 20:23:28 +0100:
> During a git bisect session I ended up with the following in the
> .git/BISECT_LOG:
>
> # bad: [38a382ae5dd4f4d04e3046816b0a41836094e538] Kobject: convert
> arch/alpha arch/arm arch/avr32 arch/blackfin arch/cris arch/frv arch/h8300
> ...
>
> From the following command you can see shat happened: the 'arch/*' from the
> commit log was expanded in the comment line in the bisect log file.
This should fix it
git-bisect.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-bisect.sh b/git-bisect.sh
index 5385249..0bb51d7 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -131,7 +131,7 @@ bisect_write() {
*) die "Bad bisect_write argument: $state" ;;
esac
git update-ref "refs/bisect/$tag" "$rev"
- echo "# $state: "$(git show-branch $rev) >>"$GIT_DIR/BISECT_LOG"
+ echo "# $state: $(git show-branch $rev)" >>"$GIT_DIR/BISECT_LOG"
test -z "$nolog" && echo "git-bisect $state $rev" >>"$GIT_DIR/BISECT_LOG"
}
--
1.5.4.1.112.g94408
prev parent reply other threads:[~2008-02-12 20:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 19:23 [BUG] git bisect should not expand file globs in log Frans Pop
2008-02-12 19:50 ` Johannes Schindelin
2008-02-12 21:10 ` Frans Pop
2008-02-12 20:06 ` Alex Riesen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080212200650.GA15258@steel.home \
--to=raa.lkml@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=elendil@planet.nl \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).