Re: libcrypto core dump in 64bit

["H.Merijn Brand" <h.m.brand@xs4all.nl>]

On Wed, 13 Feb 2008 10:04:23 +0100, "Michal Rokos" <michal@rokos.cz> wrote:

> Hello,
> 
> On Feb 12, 2008 5:38 PM, H.Merijn Brand <h.m.brand@xs4all.nl> wrote:
> > Did you get the full test suite to pass?
> 
> No - vanilla git's master won't pass (since HPUX vsnprintf is broken
> (it returns -1 when n is exceeded).

diff -purN git-1.5.4/strbuf.c git-1.5.4p/strbuf.c
--- git-1.5.4/strbuf.c  2008-02-02 05:09:01 +0100
+++ git-1.5.4p/strbuf.c 2008-02-13 11:26:56 +0100
@@ -127,7 +127,7 @@ void strbuf_addf(struct strbuf *sb, cons
        int len;
        va_list ap;

-       if (!strbuf_avail(sb))
+       if (strbuf_avail(sb) < 64)
                strbuf_grow(sb, 64);
        va_start(ap, fmt);
        len = vsnprintf(sb->buf + sb->len, sb->alloc - sb->len, fmt, ap);


> With strbuf workarounds test suite passes up to t4200-rerere.sh.
> 
> I did not try to investigate further or continue with the rest of the tests.

I did, and got here
http://www.xs4all.nl/~procura/git-1.5.4-hpux1123ipf64.diff

Note, ntar = GNU tar, and npatch is the 'patch' as the rest of the world
knows it. Our perl is in /pro. We do not want to interfere with the system
perl (and mine is always newer anyway).

git-clone is a shell script, and it's return value is ignored somewhere

/pro/3gl/LINUX/git-1.5.4p/t 122 > cat do-tests
#!/bin/sh

export TAR=ntar
rm -f *.err
for t in t[0-9]*.sh ; do
    echo $t
    sh $t > test.err 2>&1 || mv test.err $t.err
    rm -f test.err
    done
/pro/3gl/LINUX/git-1.5.4p/t 123 > ll *.err
204744 -rw-rw-rw- 1 merijn softwr  344 Feb 13 11:49 t5600-clone-fail-cleanup.sh.err
204788 -rw-rw-rw- 1 merijn softwr  458 Feb 13 11:49 t5701-clone-local.sh.err
205057 -rw-rw-rw- 1 merijn softwr 3039 Feb 13 11:50 t6002-rev-list-bisect.sh.err
204643 -rw-rw-rw- 1 merijn softwr 3980 Feb 13 11:50 t6003-rev-list-topo-order.sh.err
204808 -rw-rw-rw- 1 merijn softwr  899 Feb 13 11:50 t6022-merge-rename.sh.err
204697 -rw-rw-rw- 1 merijn softwr 1340 Feb 13 11:52 t7201-co.sh.err
204747 -rw-rw-rw- 1 merijn softwr  149 Feb 13 11:53 t9300-fast-import.sh.err
204699 -rw-rw-rw- 1 merijn softwr 1651 Feb 13 11:53 t9301-fast-export.sh.err
/pro/3gl/LINUX/git-1.5.4p/t 124 >

-- 
H.Merijn Brand         Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using & porting perl 5.6.2, 5.8.x, 5.10.x  on HP-UX 10.20, 11.00, 11.11,
& 11.23, SuSE 10.1 & 10.2, AIX 5.2, and Cygwin.       http://qa.perl.org
http://mirrors.develooper.com/hpux/            http://www.test-smoke.org
                        http://www.goldmark.org/jeff/stupid-disclaimers/