From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
"Junio C Hamano" <gitster@pobox.com>,
"Kristian Høgsberg" <krh@redhat.com>,
git@vger.kernel.org
Subject: Re: git-status producing incorrect results
Date: Thu, 14 Feb 2008 11:54:32 -0500 [thread overview]
Message-ID: <20080214165432.GA28059@coredump.intra.peff.net> (raw)
In-Reply-To: <alpine.LSU.1.00.0802141650080.30505@racer.site>
On Thu, Feb 14, 2008 at 04:51:04PM +0000, Johannes Schindelin wrote:
> I experienced the same bug, but when I looked in the tests, I had the
> impression that it tested for that very bug, and succeeded. And I did not
> have time to look into it further.
Which test did you think was checking for it?
> Speaking of tests... How about it?
I included a "from scratch" test case in my last message which I think
helps in understanding what's happening. But if we just want to test
this condition (it fails because there is a new file that is added but
not committed):
diff --git a/t/t7502-status.sh b/t/t7502-status.sh
index b64ce30..11e5655 100755
--- a/t/t7502-status.sh
+++ b/t/t7502-status.sh
@@ -128,4 +128,8 @@ test_expect_success 'status without relative paths' '
'
+test_expect_success 'status of partial commit excluding new file in index' '
+ git status modified
+'
+
test_done
next prev parent reply other threads:[~2008-02-14 16:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-14 16:45 git-status producing incorrect results Jeff King
2008-02-14 16:51 ` Johannes Schindelin
2008-02-14 16:54 ` Jeff King [this message]
2008-02-14 17:02 ` Johannes Schindelin
2008-02-14 17:02 ` Jeff King
2008-02-14 17:04 ` Linus Torvalds
2008-02-14 17:18 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080214165432.GA28059@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=krh@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).