git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Kate Rhodes <masukomi@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH 1/2] hard-code the empty tree object
Date: Fri, 15 Feb 2008 12:20:44 -0500	[thread overview]
Message-ID: <20080215172043.GA24221@sigill.intra.peff.net> (raw)
In-Reply-To: <7vabm2i1pf.fsf@gitster.siamese.dyndns.org>

On Fri, Feb 15, 2008 at 09:11:56AM -0800, Junio C Hamano wrote:

> > We also hard-code the special ref '{}' as an alias for the
> > empty tree. Users may refer to the empty tree by its
> > sha1 or by '{}'.
> 
> I think the users of hard coded empty tree are oddballs.  Let's
> not be too cute and instead leave it in the add -i patch.  {} is
> already too cute.

By "it" I assume you mean "the sha1 of the empty tree", meaning to not
include the {} bit at all?

I am fine with that, as I don't think anyone has even mentioned a
workflow where such a shorthand would be beneficial to users. The only
one I can think of is to represent some tree using diff tools (e.g., "git
diff --stat {} HEAD" instead of some variant on ls-files), but I have
never once actually wanted to do that.

Should I re-send, or do you want to just markup the existing patches?

-Peff

  reply	other threads:[~2008-02-15 17:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-14 10:32 [PATCH 1/2] hard-code the empty tree object Jeff King
2008-02-14 12:39 ` Johannes Schindelin
2008-02-14 14:03   ` Jeff King
2008-02-15 17:11 ` Junio C Hamano
2008-02-15 17:20   ` Jeff King [this message]
2008-02-15 17:42     ` Junio C Hamano
2008-02-15 18:25       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080215172043.GA24221@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=masukomi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).