From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Kate Rhodes <masukomi@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 1/2] hard-code the empty tree object
Date: Fri, 15 Feb 2008 13:25:42 -0500 [thread overview]
Message-ID: <20080215182542.GA25167@sigill.intra.peff.net> (raw)
In-Reply-To: <7vhcgaglq5.fsf@gitster.siamese.dyndns.org>
On Fri, Feb 15, 2008 at 09:42:26AM -0800, Junio C Hamano wrote:
> > Should I re-send, or do you want to just markup the existing patches?
>
> Shouldn't the previous one that uses the hardcoded empty tree
> object name good enough that is already on 'pu'?
Yes, they are fine (I hadn't looked at them that carefully before, but
it looks like you cleaned up the ordering sensibly already).
The last paragraph in the commit message of the add--interactive patch
should be removed (the implementation is no longer "hack-ish").
-Peff
prev parent reply other threads:[~2008-02-15 18:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-14 10:32 [PATCH 1/2] hard-code the empty tree object Jeff King
2008-02-14 12:39 ` Johannes Schindelin
2008-02-14 14:03 ` Jeff King
2008-02-15 17:11 ` Junio C Hamano
2008-02-15 17:20 ` Jeff King
2008-02-15 17:42 ` Junio C Hamano
2008-02-15 18:25 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080215182542.GA25167@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=masukomi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).