git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robert Schiele <rschiele@gmail.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: Martin Koegler <mkoegler@auto.tuwien.ac.at>,
	Petr Baudis <pasky@suse.cz>,
	git@vger.kernel.org
Subject: Re: Invalid html output repo.or.cz (alt-git.git)
Date: Sat, 16 Feb 2008 22:12:17 +0100	[thread overview]
Message-ID: <20080216211216.GL30676@schiele.dyndns.org> (raw)
In-Reply-To: <m3lk5kbry3.fsf@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 866 bytes --]

On Sat, Feb 16, 2008 at 11:52:42AM -0800, Jakub Narebski wrote:
> Martin Koegler <mkoegler@auto.tuwien.ac.at> writes:
> 
> > http://repo.or.cz/w/alt-git.git?a=shortlog
> > 
> > fails to load in my Seamonkey browser (Debian stable):
> > 
> > XML Parsing Error: not well-formed
> > Location: http://repo.or.cz/w/alt-git.git?a=shortlog
> > Line Number 561, Column 33:<td><i><span title="Uwe Kleine-K<span class="cntrl">\e</span>,Av<span class="cntrl">\e</span>(Bnig">Uwe Kleine ...</span></i></td>
> > --------------------------------^
> 
> It looks like gitweb uses esc_html instead of esc_param (or leaving it

Huh?  Isn't that the wrong escaping?  esc_param is for URLs not for XML
attributes in general, isn't it?

Robert

-- 
Robert Schiele
Dipl.-Wirtsch.informatiker	mailto:rschiele@gmail.com

"Quidquid latine dictum sit, altum sonatur."

[-- Attachment #2: Type: application/pgp-signature, Size: 194 bytes --]

      parent reply	other threads:[~2008-02-16 21:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-16 13:00 Invalid html output repo.or.cz (alt-git.git) Martin Koegler
2008-02-16 19:20 ` Junio C Hamano
2008-02-16 19:52 ` Jakub Narebski
2008-02-16 20:07   ` Junio C Hamano
2008-02-16 22:07     ` [PATCH] gitweb: Fix displaying unchopped argument in chop_and_escape_str Jakub Narebski
2008-02-16 21:12   ` Robert Schiele [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080216211216.GL30676@schiele.dyndns.org \
    --to=rschiele@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=mkoegler@auto.tuwien.ac.at \
    --cc=pasky@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).