git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Riesen <raa.lkml@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH] A test for commit --amend allowing changing of a very empty commit message
Date: Thu, 21 Feb 2008 20:54:38 +0100	[thread overview]
Message-ID: <20080221195438.GA6973@steel.home> (raw)

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---

Well, it fails... In current master

 t/t7501-commit.sh |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/t/t7501-commit.sh b/t/t7501-commit.sh
index 361886c..f81bf7b 100755
--- a/t/t7501-commit.sh
+++ b/t/t7501-commit.sh
@@ -345,4 +345,14 @@ test_expect_success 'amend using the message from a commit named with tag' '
 
 '
 
+test_expect_success 'allow amend of an empty message' '
+
+	git reset --hard &&
+	sha=$(:|git commit-tree HEAD^{tree} -p HEAD) &&
+	git reset --hard $sha &&
+	git commit --amend -mChanged &&
+	git cat-file commit HEAD|tail -n1|grep ^Changed$
+
+'
+
 test_done
-- 
1.5.4.2.204.g6d0ab

             reply	other threads:[~2008-02-21 19:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-21 19:54 Alex Riesen [this message]
2008-02-21 20:23 ` [PATCH] A test for commit --amend allowing changing of a very empty commit message Junio C Hamano
2008-02-21 20:35   ` Alex Riesen
2008-02-21 20:38     ` [PATCH] Fix amending of a commit with an empty message Alex Riesen
2008-02-21 20:56       ` Junio C Hamano
2008-02-21 21:32         ` Alex Riesen
2008-02-21 22:01           ` Junio C Hamano
2008-02-21 20:57     ` [PATCH] A test for commit --amend allowing changing of a very empty commit message Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080221195438.GA6973@steel.home \
    --to=raa.lkml@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).