From: Alex Riesen <raa.lkml@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] A test for commit --amend allowing changing of a very empty commit message
Date: Thu, 21 Feb 2008 21:35:06 +0100 [thread overview]
Message-ID: <20080221203506.GA20143@steel.home> (raw)
In-Reply-To: <7vwsoyt5xt.fsf@gitster.siamese.dyndns.org>
Junio C Hamano, Thu, Feb 21, 2008 21:23:10 +0100:
> Alex Riesen <raa.lkml@gmail.com> writes:
> >
> > Well, it fails... In current master
>
> Then please mark it with test_expect_failure.
That's because I expect it to be fixed (in the next mail)
> > +test_expect_success 'allow amend of an empty message' '
> > +
> > + git reset --hard &&
> > + sha=$(:|git commit-tree HEAD^{tree} -p HEAD) &&
>
> You do not have to pipe; </dev/null would do ;-).
Sadly: no. There are very challenged systems. Like, for instance, ones
having no idea of what "/dev/null" is. Windows/Cygwin/ActiveState Perl
in a bloody stupid corporate combination.
I'm trying to minimize differences between my tree for my system at
work and the main tree. It is honestly the only purpose for this
construct.
next prev parent reply other threads:[~2008-02-21 20:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 19:54 [PATCH] A test for commit --amend allowing changing of a very empty commit message Alex Riesen
2008-02-21 20:23 ` Junio C Hamano
2008-02-21 20:35 ` Alex Riesen [this message]
2008-02-21 20:38 ` [PATCH] Fix amending of a commit with an empty message Alex Riesen
2008-02-21 20:56 ` Junio C Hamano
2008-02-21 21:32 ` Alex Riesen
2008-02-21 22:01 ` Junio C Hamano
2008-02-21 20:57 ` [PATCH] A test for commit --amend allowing changing of a very empty commit message Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080221203506.GA20143@steel.home \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).