From: Alex Riesen <raa.lkml@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix amending of a commit with an empty message
Date: Thu, 21 Feb 2008 22:32:04 +0100 [thread overview]
Message-ID: <20080221213204.GC20143@steel.home> (raw)
In-Reply-To: <7vmyput4dn.fsf@gitster.siamese.dyndns.org>
Junio C Hamano, Thu, Feb 21, 2008 21:56:52 +0100:
> Alex Riesen <raa.lkml@gmail.com> writes:
>
> > In this one. I am a bit unsure regarding the change (it looks a little
> > too strong), even though it passes the test suite.
>
> I think that is because your new test is faulty.
>
> Instead of ':' I complained about, try having "echo foo" there.
> I think it will still fail.
Oh, indeed. The commit to amend does not introduce any changes.
> Having said that, here is a quiz. When the user says "git
> commit --amend", what are the valid reasons not to allow it,
> other than:
>
> - the index is unmerged.
> - the branch is yet to be born.
There are no tree changes in the commit to be amended.
And if there is a strong wish to do just the amendment,
there is always --allow-empty.
Ok, it must have been the amount of err... tee I just had.
next prev parent reply other threads:[~2008-02-21 21:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 19:54 [PATCH] A test for commit --amend allowing changing of a very empty commit message Alex Riesen
2008-02-21 20:23 ` Junio C Hamano
2008-02-21 20:35 ` Alex Riesen
2008-02-21 20:38 ` [PATCH] Fix amending of a commit with an empty message Alex Riesen
2008-02-21 20:56 ` Junio C Hamano
2008-02-21 21:32 ` Alex Riesen [this message]
2008-02-21 22:01 ` Junio C Hamano
2008-02-21 20:57 ` [PATCH] A test for commit --amend allowing changing of a very empty commit message Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080221213204.GC20143@steel.home \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).