git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: "David Kågedal" <davidk@lysator.liu.se>
Cc: Git Mailing List <git@vger.kernel.org>,
	Alexandre Julliard <julliard@winehq.org>
Subject: Re: [PATCH] git.el: Add a git-grep command
Date: Fri, 22 Feb 2008 11:21:34 +0100	[thread overview]
Message-ID: <200802221121.35706.jnareb@gmail.com> (raw)
In-Reply-To: <87tzk19wn5.fsf@lysator.liu.se>

On Fri, 22 Feb 2008, David Kågedal wrote:
> Jakub Narebski <jnareb@gmail.com> writes:
>> David Kågedal <davidk@lysator.liu.se> writes:
>>
>>> This works for me, but before including it someone else should try
>>> it. It might only work in Emacs 22, for instance.
>>
>> emacs -batch -f batch-byte-compile git.el
>> [...]
>> While compiling toplevel forms in file git/contrib/emacs/git.el:
>>   !! File error (("Cannot open load file" "grep"))
>> Done
>> make: *** [git.elc] Error 1
>>
>> 1078:[emacs@git/contrib/emacs]# emacs --version
>> GNU Emacs 21.4.1
> 
> As I suspected. The problem is that the grep commands were rewritten
> for Emacs 22, and lots of it can be reused. So to write a similar
> command for Emacs 21 probably requires a bit more work. And since I
> use Emacs 22 I'm not sure I will feel motivated enough...

Could you make it at least conditional on the Emacs version used,
or even better depending on the fact if "grep" 'library' is available?

I'd like to be able to use git.el with my Emacs, even without some
functionality. TIA.
-- 
Jakub Narebski
Poland

  reply	other threads:[~2008-02-22 10:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-19 13:03 [PATCH] git.el: Add a git-grep command David Kågedal
2008-02-21 13:12 ` Remi Vanicat
2008-02-21 14:55   ` David Kågedal
2008-02-22  2:00 ` Xavier Maillard
2008-02-22  7:31 ` Karl Hasselström
2008-02-22  9:15   ` David Kågedal
2008-02-22 11:55     ` Karl Hasselström
2008-02-22  9:03 ` Jakub Narebski
2008-02-22  9:18   ` David Kågedal
2008-02-22 10:21     ` Jakub Narebski [this message]
2008-02-22 10:44       ` David Kågedal
2008-02-22 11:11         ` Remi Vanicat
2008-02-22 11:43           ` David Kågedal
2008-02-23  2:00           ` Xavier Maillard
2008-02-23 19:39             ` Remi Vanicat
2008-02-23 22:41               ` Xavier Maillard
2008-02-24  2:00               ` Xavier Maillard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802221121.35706.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=davidk@lysator.liu.se \
    --cc=git@vger.kernel.org \
    --cc=julliard@winehq.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).