git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] gitweb: Fix bugs in git_search_grep_body: it's length(), not len()
@ 2008-02-23 21:37 Jakub Narebski
  0 siblings, 0 replies; only message in thread
From: Jakub Narebski @ 2008-02-23 21:37 UTC (permalink / raw)
  To: git, Junio C Hamano; +Cc: Jean-Baptiste Quenot, Jakub Narebski


Use int(<expr>/2) to get integer value for a substring length.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
I'm very very sorry. I though I have tested this, but somehow it
slipped through; most probably I have tested older version.

 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 326e27c..e8226b1 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -3792,7 +3792,7 @@ sub git_search_grep_body {
 			if ($line =~ m/^(.*)($search_regexp)(.*)$/i) {
 				my ($lead, $match, $trail) = ($1, $2, $3);
 				$match = chop_str($match, 70, 5);       # in case match is very long
-				my $contextlen = (80 - len($match))/2;  # is left for the remainder
+				my $contextlen = int((80 - length($match))/2); # for the remainder
 				$contextlen = 30 if ($contextlen > 30); # but not too much
 				$lead  = chop_str($lead,  $contextlen, 10);
 				$trail = chop_str($trail, $contextlen, 10);

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2008-02-23 21:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-23 21:37 [PATCH] gitweb: Fix bugs in git_search_grep_body: it's length(), not len() Jakub Narebski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).