From: "Shawn O. Pearce" <spearce@spearce.org>
To: Martin Koegler <mkoegler@auto.tuwien.ac.at>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/4] add generic, type aware object chain walker
Date: Sun, 24 Feb 2008 22:04:04 -0500 [thread overview]
Message-ID: <20080225030404.GL8410@spearce.org> (raw)
In-Reply-To: <12038642373342-git-send-email-mkoegler@auto.tuwien.ac.at>
Martin Koegler <mkoegler@auto.tuwien.ac.at> wrote:
> +static int fsck_walk_commit(struct commit *commit, fsck_walk_func walk, void *data)
> +{
> + struct commit_list *parents = commit->parents;
> + int result;
> +
> + if(parse_commit(commit))
> + return -1;
Hmm. Don't you need to get commit->parenst *after* it is parsed,
and not before?
> @@ -0,0 +1,10 @@
> +#ifndef GIT_FSCK_H
> +#define GIT_FSCK_H
> +
> +#define OBJ_ANY OBJ_BAD
Its unclear why this macro is necessary.
--
Shawn.
next prev parent reply other threads:[~2008-02-25 3:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-24 14:43 [PATCH 1/4] add generic, type aware object chain walker Martin Koegler
2008-02-24 14:43 ` [PATCH 2/4] builtin-fsck: move away from object-refs Martin Koegler
2008-02-24 14:43 ` [PATCH 3/4] Remove unused object-ref code Martin Koegler
2008-02-24 14:43 ` [PATCH 4/4] builtin-fsck: reports missing parent commits Martin Koegler
2008-02-25 3:04 ` Shawn O. Pearce [this message]
2008-02-25 7:26 ` [PATCH 1/4] add generic, type aware object chain walker Martin Koegler
2008-02-25 7:37 ` Junio C Hamano
2008-02-25 7:52 ` Martin Koegler
2008-02-25 8:02 ` Junio C Hamano
2008-02-25 8:06 ` Martin Koegler
2008-02-25 8:12 ` Shawn O. Pearce
2008-02-25 17:35 ` Nicolas Pitre
2008-02-25 8:04 ` Shawn O. Pearce
2008-02-25 17:49 ` Nicolas Pitre
2008-02-25 3:08 ` Junio C Hamano
2008-02-25 7:46 ` Martin Koegler
2008-02-25 7:59 ` Junio C Hamano
2008-02-25 8:21 ` Martin Koegler
2008-02-25 8:10 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080225030404.GL8410@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mkoegler@auto.tuwien.ac.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).