* [PATCH] Correct fast-export file mode strings to match fast-import standard
@ 2008-02-25 3:57 Shawn O. Pearce
2008-02-26 0:54 ` Johannes Schindelin
0 siblings, 1 reply; 2+ messages in thread
From: Shawn O. Pearce @ 2008-02-25 3:57 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, Johannes Schindelin, Ian Clatworthy
The fast-import file format does not expect leading '0' in front
of a file mode; that is we want '100644' and '0100644'.
Thanks to Ian Clatworthy of the Bazaar project for noticing the
difference in output/input.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
builtin-fast-export.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin-fast-export.c b/builtin-fast-export.c
index 49b54de..e1c5630 100755
--- a/builtin-fast-export.c
+++ b/builtin-fast-export.c
@@ -123,7 +123,7 @@ static void show_filemodify(struct diff_queue_struct *q,
printf("D %s\n", spec->path);
else {
struct object *object = lookup_object(spec->sha1);
- printf("M 0%06o :%d %s\n", spec->mode,
+ printf("M %06o :%d %s\n", spec->mode,
get_object_mark(object), spec->path);
}
}
--
1.5.4.3.295.g6b554
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Correct fast-export file mode strings to match fast-import standard
2008-02-25 3:57 [PATCH] Correct fast-export file mode strings to match fast-import standard Shawn O. Pearce
@ 2008-02-26 0:54 ` Johannes Schindelin
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Schindelin @ 2008-02-26 0:54 UTC (permalink / raw)
To: Shawn O. Pearce; +Cc: Junio C Hamano, git, Ian Clatworthy
Hi,
On Sun, 24 Feb 2008, Shawn O. Pearce wrote:
> The fast-import file format does not expect leading '0' in front
> of a file mode; that is we want '100644' and '0100644'.
s/and/& not/
> - printf("M 0%06o :%d %s\n", spec->mode,
> + printf("M %06o :%d %s\n", spec->mode,
Definitely embarassing.
Thanks,
Dscho
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-26 0:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-25 3:57 [PATCH] Correct fast-export file mode strings to match fast-import standard Shawn O. Pearce
2008-02-26 0:54 ` Johannes Schindelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).