From: Christian Couder <chriscool@tuxfamily.org>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 1/3] help: use parseopt
Date: Mon, 25 Feb 2008 07:50:52 +0100 [thread overview]
Message-ID: <200802250750.53047.chriscool@tuxfamily.org> (raw)
In-Reply-To: <20080224221655.GB31309@coredump.intra.peff.net>
Le dimanche 24 février 2008, Jeff King a écrit :
> This patch converts cmd_help to use parseopt, along with a
> few style cleanups, including:
>
> - enum constants are now ALL_CAPS
Ok.
> - parse_help_format returns an enum value rather than
> setting a global as a side effect
Nice cleanup.
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> Sorry, the diff turned out quite messy because of the cleanups. It's
> probably easier to just read the result.
Or could you send the cleanups in some separated patches ?
Thanks in advance,
Christian.
next prev parent reply other threads:[~2008-02-25 6:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1203890846.git.peff@peff.net>
2008-02-24 22:16 ` [PATCH 1/3] help: use parseopt Jeff King
2008-02-25 6:50 ` Christian Couder [this message]
2008-02-25 6:57 ` Jeff King
2008-02-25 7:16 ` Junio C Hamano
2008-02-24 22:17 ` [PATCH 2/3] make alias lookup a public, procedural function Jeff King
2008-02-24 22:17 ` [PATCH 3/3] help: respect aliases Jeff King
2008-02-25 2:10 ` Jay Soffian
2008-02-26 12:43 ` Johannes Schindelin
2008-02-26 14:56 ` Jay Soffian
2008-02-26 15:15 ` Johannes Schindelin
2008-02-26 20:14 ` Junio C Hamano
2008-02-26 20:31 ` Jay Soffian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802250750.53047.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).