From: Jeff King <peff@peff.net>
To: Brandon Casey <casey@nrlssc.navy.mil>
Cc: Andreas Ericsson <ae@op5.se>,
Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>, Nicolas Pitre <nico@cam.org>
Subject: Re: [PATCH] pack-objects: Print a message describing the number of threads for packing
Date: Tue, 26 Feb 2008 02:49:33 -0500 [thread overview]
Message-ID: <20080226074933.GA3485@coredump.intra.peff.net> (raw)
In-Reply-To: <47BF812A.4020205@nrlssc.navy.mil>
On Fri, Feb 22, 2008 at 08:12:58PM -0600, Brandon Casey wrote:
> + if (progress)
> + fprintf(stderr, "Using %d pack threads.\n",
> + delta_search_threads);
I just noticed that this was in next. Do we really need to display this
message? A considerable amount of discussion went into reducing git's
chattiness and clutter during push and fetch, and I feel like this is a
step backwards (yes, I know most people won't see it if they don't build
with THREADED_DELTA_SEARCH).
Can we show it only if threads != 1? Only if we auto-detected the number
of threads and it wasn't 1?
-Peff
next prev parent reply other threads:[~2008-02-26 7:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 8:20 [PATCH] pack-objects: Add runtime detection of online CPU's Andreas Ericsson
2008-02-12 8:27 ` Shawn O. Pearce
2008-02-12 8:49 ` Johannes Sixt
2008-02-12 11:18 ` Bert Wesarg
2008-02-12 12:21 ` Andreas Ericsson
2008-02-12 14:52 ` Michael Hendricks
2008-02-12 15:44 ` Brandon Casey
2008-02-23 2:11 ` Brandon Casey
2008-02-23 8:18 ` Andreas Ericsson
[not found] ` <1203732369-30314-1-git-send-email-casey@nrlssc.navy.mil>
2008-02-23 2:12 ` [PATCH] pack-objects: Print a message describing the number of threads for packing Brandon Casey
2008-02-26 7:49 ` Jeff King [this message]
2008-02-26 8:00 ` Junio C Hamano
2008-02-26 8:06 ` Jeff King
2008-02-26 9:19 ` Junio C Hamano
2008-02-26 9:33 ` Jeff King
2008-02-26 9:40 ` Andreas Ericsson
2008-02-26 15:53 ` Brandon Casey
2008-02-26 17:05 ` Nicolas Pitre
2008-02-26 21:25 ` Jeff King
2008-02-26 21:21 ` Jeff King
2008-02-26 22:50 ` Brandon Casey
2008-02-26 23:04 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080226074933.GA3485@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=ae@op5.se \
--cc=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).