From: Mike Hommey <mh@glandium.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add test for git rebase --abort
Date: Sat, 1 Mar 2008 09:15:11 +0100 [thread overview]
Message-ID: <20080301081511.GA30613@glandium.org> (raw)
In-Reply-To: <20080301074511.GB26767@glandium.org>
On Sat, Mar 01, 2008 at 08:45:11AM +0100, Mike Hommey wrote:
> On Sat, Mar 01, 2008 at 08:36:12AM +0100, Mike Hommey wrote:
> > On Fri, Feb 29, 2008 at 03:26:01PM -0800, Junio C Hamano wrote:
> > > Mike Hommey <mh@glandium.org> writes:
> > >
> > > > The failing test is the third. I don't have enough knowledge in git-rebase
> > > > to write an appropriate fix, but the problem seems to be in
> > > > move_to_original_branch, where testing head_name doesn't seem appropriate.
> > >
> > > Please mark such an "expected to succeed but fails due to
> > > suspected bug" with test_expect_failure.
> >
> > I was kind of expecting the bug would be fixed before the test be
> > included ;)
>
> ... and the test actually passes with v1.5.0. I'll bisect.
... and I'm even the one to blame
fb6e4e1f3f048898677f3cf177bfcaf60123bd5c is first bad commit
Mike
next prev parent reply other threads:[~2008-03-01 8:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-29 22:08 [PATCH] Add test for git rebase --abort Mike Hommey
2008-02-29 23:26 ` Junio C Hamano
2008-02-29 23:39 ` Johannes Schindelin
2008-03-01 7:36 ` Mike Hommey
2008-03-01 7:41 ` Junio C Hamano
2008-03-01 7:45 ` Mike Hommey
2008-03-01 8:15 ` Mike Hommey [this message]
2008-03-01 9:17 ` Junio C Hamano
2008-03-01 10:32 ` [PATCH] Fix git reset --abort not restoring the right commit under some conditions Mike Hommey
2008-03-01 11:11 ` Mike Hommey
2008-03-02 2:27 ` Junio C Hamano
2008-03-02 3:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080301081511.GA30613@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).