From: Mike Hommey <mh@glandium.org>
To: Gerrit Pape <pape@smarden.org>
Cc: git@vger.kernel.org
Subject: Re: git-http-fetch segfault, curl 7.18.0
Date: Sun, 2 Mar 2008 20:23:55 +0100 [thread overview]
Message-ID: <20080302192355.GA625@glandium.org> (raw)
In-Reply-To: <20080302190857.11027.qmail@28c5bbafb32cb2.315fe32.mid.smarden.org>
On Sun, Mar 02, 2008 at 07:08:57PM +0000, Gerrit Pape wrote:
> Hi, as reported through http://bugs.debian.org/468836, I can reproduce
> with current maint branch on Debian/unstable, but I don't know whether
> it's a problem in curl, or in git. Maybe anyone with some experience
> in curl can help on this?
>
> gdb gives this
(...)
valgrind gives better insight:
==862== Invalid read of size 4
==862== at 0x493B32: fill_active_slots (http.c:441)
==862== by 0x493CF9: step_active_slots (http.c:459)
==862== by 0x493D6E: run_active_slot (http.c:479)
==862== by 0x493F8B: http_cleanup (http.c:296)
==862== by 0x494CA8: cleanup (http-walker.c:900)
==862== by 0x4911D6: walker_free (walker.c:315)
==862== by 0x44A149: cmd_http_fetch (builtin-http-fetch.c:81)
==862== by 0x404247: handle_internal_command (git.c:248)
==862== by 0x4049D4: main (git.c:412)
==862== Address 0x7c7c558 is 16 bytes inside a block of size 72 free'd
==862== at 0x4C20B2E: free (vg_replace_malloc.c:323)
==862== by 0x493F47: http_cleanup (http.c:301)
==862== by 0x494CA8: cleanup (http-walker.c:900)
==862== by 0x4911D6: walker_free (walker.c:315)
==862== by 0x44A149: cmd_http_fetch (builtin-http-fetch.c:81)
==862== by 0x404247: handle_internal_command (git.c:248)
==862== by 0x4049D4: main (git.c:412)
==862==
==862== Invalid read of size 8
==862== at 0x493B50: fill_active_slots (http.c:445)
==862== by 0x493CF9: step_active_slots (http.c:459)
==862== by 0x493D6E: run_active_slot (http.c:479)
==862== by 0x493F8B: http_cleanup (http.c:296)
==862== by 0x494CA8: cleanup (http-walker.c:900)
==862== by 0x4911D6: walker_free (walker.c:315)
==862== by 0x44A149: cmd_http_fetch (builtin-http-fetch.c:81)
==862== by 0x404247: handle_internal_command (git.c:248)
==862== by 0x4049D4: main (git.c:412)
==862== Address 0x7c7c588 is 64 bytes inside a block of size 72 free'd
==862== at 0x4C20B2E: free (vg_replace_malloc.c:323)
==862== by 0x493F47: http_cleanup (http.c:301)
==862== by 0x494CA8: cleanup (http-walker.c:900)
==862== by 0x4911D6: walker_free (walker.c:315)
==862== by 0x44A149: cmd_http_fetch (builtin-http-fetch.c:81)
==862== by 0x404247: handle_internal_command (git.c:248)
==862== by 0x4049D4: main (git.c:412)
==862==
==862== Invalid read of size 8
==862== at 0x493BFD: process_curl_messages (http.c:74)
==862== by 0x493CF4: step_active_slots (http.c:458)
==862== by 0x493D6E: run_active_slot (http.c:479)
==862== by 0x493F8B: http_cleanup (http.c:296)
==862== by 0x494CA8: cleanup (http-walker.c:900)
==862== by 0x4911D6: walker_free (walker.c:315)
==862== by 0x44A149: cmd_http_fetch (builtin-http-fetch.c:81)
==862== by 0x404247: handle_internal_command (git.c:248)
==862== by 0x4049D4: main (git.c:412)
==862== Address 0x7c7c548 is 0 bytes inside a block of size 72 free'd
==862== at 0x4C20B2E: free (vg_replace_malloc.c:323)
==862== by 0x493F47: http_cleanup (http.c:301)
==862== by 0x494CA8: cleanup (http-walker.c:900)
==862== by 0x4911D6: walker_free (walker.c:315)
==862== by 0x44A149: cmd_http_fetch (builtin-http-fetch.c:81)
==862== by 0x404247: handle_internal_command (git.c:248)
==862== by 0x4049D4: main (git.c:412)
==862==
==862== Invalid read of size 8
==862== at 0x493BF0: process_curl_messages (http.c:76)
==862== by 0x493CF4: step_active_slots (http.c:458)
==862== by 0x493D6E: run_active_slot (http.c:479)
==862== by 0x493F8B: http_cleanup (http.c:296)
==862== by 0x494CA8: cleanup (http-walker.c:900)
==862== by 0x4911D6: walker_free (walker.c:315)
==862== by 0x44A149: cmd_http_fetch (builtin-http-fetch.c:81)
==862== by 0x404247: handle_internal_command (git.c:248)
==862== by 0x4049D4: main (git.c:412)
==862== Address 0x7c7c588 is 64 bytes inside a block of size 72 free'd
==862== at 0x4C20B2E: free (vg_replace_malloc.c:323)
==862== by 0x493F47: http_cleanup (http.c:301)
==862== by 0x494CA8: cleanup (http-walker.c:900)
==862== by 0x4911D6: walker_free (walker.c:315)
==862== by 0x44A149: cmd_http_fetch (builtin-http-fetch.c:81)
==862== by 0x404247: handle_internal_command (git.c:248)
==862== by 0x4049D4: main (git.c:412)
==862==
==862== Invalid read of size 4
==862== at 0x494372: get_active_slot (http.c:336)
==862== by 0x49504A: start_object_request (http-walker.c:195)
==862== by 0x495413: fill_active_slot (http-walker.c:321)
==862== by 0x493B1C: fill_active_slots (http.c:433)
==862== by 0x493CF9: step_active_slots (http.c:459)
==862== by 0x493D6E: run_active_slot (http.c:479)
==862== by 0x493F8B: http_cleanup (http.c:296)
==862== by 0x494CA8: cleanup (http-walker.c:900)
==862== by 0x4911D6: walker_free (walker.c:315)
==862== by 0x44A149: cmd_http_fetch (builtin-http-fetch.c:81)
==862== by 0x404247: handle_internal_command (git.c:248)
==862== by 0x4049D4: main (git.c:412)
==862== Address 0x7c7c558 is 16 bytes inside a block of size 72 free'd
==862== at 0x4C20B2E: free (vg_replace_malloc.c:323)
==862== by 0x493F47: http_cleanup (http.c:301)
==862== by 0x494CA8: cleanup (http-walker.c:900)
==862== by 0x4911D6: walker_free (walker.c:315)
==862== by 0x44A149: cmd_http_fetch (builtin-http-fetch.c:81)
==862== by 0x404247: handle_internal_command (git.c:248)
==862== by 0x4049D4: main (git.c:412)
==862==
==862== Invalid read of size 8
==862== at 0x494379: get_active_slot (http.c:337)
==862== by 0x49504A: start_object_request (http-walker.c:195)
==862== by 0x495413: fill_active_slot (http-walker.c:321)
==862== by 0x493B1C: fill_active_slots (http.c:433)
==862== by 0x493CF9: step_active_slots (http.c:459)
==862== by 0x493D6E: run_active_slot (http.c:479)
==862== by 0x493F8B: http_cleanup (http.c:296)
==862== by 0x494CA8: cleanup (http-walker.c:900)
==862== by 0x4911D6: walker_free (walker.c:315)
==862== by 0x44A149: cmd_http_fetch (builtin-http-fetch.c:81)
==862== by 0x404247: handle_internal_command (git.c:248)
==862== by 0x4049D4: main (git.c:412)
==862== Address 0x7c7c588 is 64 bytes inside a block of size 72 free'd
==862== at 0x4C20B2E: free (vg_replace_malloc.c:323)
==862== by 0x493F47: http_cleanup (http.c:301)
==862== by 0x494CA8: cleanup (http-walker.c:900)
==862== by 0x4911D6: walker_free (walker.c:315)
==862== by 0x44A149: cmd_http_fetch (builtin-http-fetch.c:81)
==862== by 0x404247: handle_internal_command (git.c:248)
==862== by 0x4049D4: main (git.c:412)
It seems there is something wrong going on with slots...
Mike
next prev parent reply other threads:[~2008-03-02 19:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-02 19:08 git-http-fetch segfault, curl 7.18.0 Gerrit Pape
2008-03-02 19:23 ` Mike Hommey [this message]
2008-03-02 20:03 ` Mike Hommey
2008-03-02 20:20 ` Daniel Barkalow
2008-03-02 20:33 ` Mike Hommey
2008-03-02 20:28 ` [PATCH] Fix random crashes in http_cleanup() Mike Hommey
2008-03-03 10:01 ` Gerrit Pape
2008-03-03 19:30 ` [PATCH v2] " Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080302192355.GA625@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=pape@smarden.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).