From: Alex Riesen <raa.lkml@gmail.com>
To: Carlos Rica <jasampler@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Make builtin-reset.c use parse_options.
Date: Sun, 2 Mar 2008 22:38:43 +0100 [thread overview]
Message-ID: <20080302213843.GA13954@steel.home> (raw)
In-Reply-To: <1b46aba20803021040ofec56b9q120a654a192eec09@mail.gmail.com>
Carlos Rica, Sun, Mar 02, 2008 19:40:09 +0100:
> On Sun, Mar 2, 2008 at 4:55 PM, Alex Riesen <raa.lkml@gmail.com> wrote:
> >
> > "static const struct option options[] = {"
>
> The other files using parse_options have only "static", or nothing.
Well, they all miss something. Besides all nice things about static
syntax checking, the compiler (GCC) can optimize string constants to
use the same data (not that it is interesting in this particular
case).
> To make "options" static, then reset_type and quiet should be
> static too, otherwise it cannot compile (in my system).
Of course. Is it a problem for user-interface level code?
> I don't know benefits of making all of them "static".
It is initialized statically.
> Has this been discussed previously?
Yeah. Sometime around 1972.
next prev parent reply other threads:[~2008-03-02 21:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-01 16:29 [PATCH] Make builtin-reset.c use parse_options Carlos Rica
2008-03-02 2:53 ` Junio C Hamano
2008-03-02 12:37 ` Carlos Rica
2008-03-02 16:18 ` Junio C Hamano
2008-03-03 14:07 ` Carlos Rica
2008-03-03 17:07 ` Pierre Habouzit
2008-03-03 22:40 ` Junio C Hamano
2008-03-04 9:45 ` Pierre Habouzit
2008-03-02 16:32 ` Johannes Schindelin
2008-03-02 9:40 ` Alex Riesen
2008-03-02 12:54 ` Carlos Rica
2008-03-02 15:55 ` Alex Riesen
2008-03-02 18:40 ` Carlos Rica
2008-03-02 21:38 ` Alex Riesen [this message]
2008-03-03 14:39 ` Carlos Rica
-- strict thread matches above, loose matches on Subject: below --
2008-03-04 22:11 Carlos Rica
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080302213843.GA13954@steel.home \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jasampler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).