git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: Re* [PATCH] allow git-am to run in a subdirectory
Date: Mon, 3 Mar 2008 01:58:08 -0500	[thread overview]
Message-ID: <20080303065808.GA22810@coredump.intra.peff.net> (raw)
In-Reply-To: <7vlk50joe0.fsf_-_@gitster.siamese.dyndns.org>

On Sun, Mar 02, 2008 at 10:46:31PM -0800, Junio C Hamano wrote:

> > The problem is that I need to turn the original "$@" into a new "$@"
> > that is correctly prefixed, which requires proper quoting.
> 
> Perhaps like this?

Yes. For some reason I didn't think of doing 'set "$@" "$new"' to
rebuild the list one by one.

> +	if test -n "$prefix" && test $# != 0
> +	then
> +		first=t
> +		for arg
> +		do
> +			test -n "$first" && {
> +				set x
> +				first=
> +			}
> +			case "$arg" in
> +			/*)
> +				set "$@" "$arg" ;;
> +			*)
> +				set "$@" "$prefix$arg" ;;
> +			esac
> +		done
> +		shift
> +	fi

This handles the mailbox parameters. The only other file parameter is
$dotest. If I do "cd t && git am --dotest=.foo", then should it be
"t/.foo" or ".foo"?

-Peff

  reply	other threads:[~2008-03-03  6:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-01  6:22 [PATCH] allow git-am to run in a subdirectory Jeff King
2008-03-01  7:38 ` Junio C Hamano
2008-03-01  8:12   ` Jeff King
2008-03-01  8:15     ` Junio C Hamano
2008-03-01  8:20       ` Jeff King
2008-03-03  3:26     ` Jay Soffian
2008-03-03  6:46     ` Re* " Junio C Hamano
2008-03-03  6:58       ` Jeff King [this message]
2008-03-03  7:08         ` Junio C Hamano
2008-03-03 11:53           ` Johannes Schindelin
2008-03-03 17:01             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080303065808.GA22810@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).