From: Christian Couder <chriscool@tuxfamily.org>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Junio C Hamano <gitster@pobox.com>, Xavier Maillard <xma@gnu.org>,
git@vger.kernel.org, nanako3@bluebottle.com, pascal@obry.net
Subject: Re: [PATCH] Redirect stderr to a pipe before redirecting stdout to stderr
Date: Mon, 3 Mar 2008 08:52:42 +0100 [thread overview]
Message-ID: <200803030852.43254.chriscool@tuxfamily.org> (raw)
In-Reply-To: <20080303073307.GG8410@spearce.org>
Le lundi 3 mars 2008, Shawn O. Pearce a écrit :
> Christian Couder <chriscool@tuxfamily.org> wrote:
> > With this patch, in the 'start_command' function after forking
> > we now take care of stderr in the child process before stdout.
> >
> > This way if 'start_command' is called with a 'child_process'
> > argument like this:
> >
> > .err = -1;
> > .stdout_to_stderr = 1;
> >
> > then stderr will be redirected to a pipe before stdout is
> > redirected to stderr. So we can now get the process' stdout
> > from the pipe (as well as its stderr).
>
> I'm in favor of this patch. My series to add sideband support
> to send-pack/receive-pack (aka push) needed it for the hooks.
Now that you say it, I remember having seen your patch, so please take
ownership of this patch.
Thanks,
Christian.
next prev parent reply other threads:[~2008-03-03 7:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-03 7:21 [PATCH] Redirect stderr to a pipe before redirecting stdout to stderr Christian Couder
2008-03-03 7:33 ` Shawn O. Pearce
2008-03-03 7:52 ` Christian Couder [this message]
2008-03-03 8:07 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803030852.43254.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nanako3@bluebottle.com \
--cc=pascal@obry.net \
--cc=spearce@spearce.org \
--cc=xma@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).