git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Herland <johan@herland.net>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: git@vger.kernel.org,
	"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
	"Kristian Høgsberg" <krh@redhat.com>,
	"Santi Béjar" <sbejar@gmail.com>
Subject: [PATCH] Add test for cloning with "--reference" repo being a subset of source repo
Date: Mon, 03 Mar 2008 10:04:16 +0100	[thread overview]
Message-ID: <200803031004.16568.johan@herland.net> (raw)
In-Reply-To: <alpine.LNX.1.00.0803021128510.19665@iabervon.org>

The first test in this series tests "git clone -l -s --reference B A C",
where repo B is a superset of repo A (A has one commit, B has the same
commit plus another). In this case, all objects to be cloned are already
present in B.

However, we should also test the case where the "--reference" repo is a
_subset_ of the source repo (e.g. "git clone -l -s --reference A B C"),
i.e. some objects are not available in the "--reference" repo, and will
have to be found in the source repo.

Signed-off-by: Johan Herland <johan@herland.net>
---

On Sunday 02 March 2008, Daniel Barkalow wrote:
> In any case, I've got my current version at
> 
> git://iabervon.org/~barkalow/git.git builtin-clone

Thanks, it already looks much better than the initial version. :)

However, this added test currently fails for me with the following output:

repo is /home/johan/git/git/t/trash/B/.git
dir is E
Initialize E/.git
Initialized empty Git repository in E/.git/
Okay
Wrote /home/johan/git/git/t/trash/A/.git/objects
 to E/.git/objects/info/alternates
Wrote /home/johan/git/git/t/trash/B/.git/objects
 to E/.git/objects/info/alternates
Get for /home/johan/git/git/t/trash/B/.git
error: Trying to write ref refs/remotes/origin/master with nonexistant object 276cf9e94287a7c4e6f79b2724460e9650fa4871
fatal: Cannot update the ref 'refs/remotes/origin/master'.
Remove junk E/.git
Remove junk E

The same test work well with git-clone.sh.
Not sure what's going on here, yet, but I thought I'd give you a heads up.

...Johan


 t/t5700-clone-reference.sh |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/t/t5700-clone-reference.sh b/t/t5700-clone-reference.sh
index b6a5486..d318780 100755
--- a/t/t5700-clone-reference.sh
+++ b/t/t5700-clone-reference.sh
@@ -113,4 +113,9 @@ diff expected current'
 
 cd "$base_dir"
 
+test_expect_success 'cloning with reference being subset of source (-l -s)' \
+'git clone -l -s --reference A B E'
+
+cd "$base_dir"
+
 test_done
-- 
1.5.4.3.328.gcaed


  parent reply	other threads:[~2008-03-03  9:05 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-25 21:12 [RFC] Build in clone Daniel Barkalow
2008-02-26  2:21 ` Johan Herland
2008-02-26 11:14   ` Johannes Schindelin
2008-02-26 12:19     ` Johan Herland
2008-02-26 12:58       ` Johan Herland
2008-02-26 13:37         ` Johan Herland
2008-02-26 15:35           ` [PATCH] Fix premature free of ref_lists while writing temporary refs to file Johan Herland
2008-02-26 15:42             ` Johannes Schindelin
2008-02-26 17:17               ` Johan Herland
2008-02-26 23:07               ` Daniel Barkalow
2008-02-26 23:11                 ` Johan Herland
2008-02-26 15:40   ` [PATCH] Fix premature call to git_config() causing t1020-subdirectory to fail Johan Herland
2008-02-26 15:47     ` Johannes Schindelin
2008-02-26 22:12     ` Daniel Barkalow
2008-02-26 22:40       ` Johannes Schindelin
2008-02-26 22:49         ` Daniel Barkalow
2008-02-27  0:20           ` Junio C Hamano
2008-02-27  0:53             ` Daniel Barkalow
2008-02-27  1:34               ` Junio C Hamano
2008-02-27 19:47                 ` Daniel Barkalow
2008-02-27 20:09                   ` Junio C Hamano
2008-02-27 20:31                     ` Daniel Barkalow
2008-02-26 17:36   ` [RFC] Build in clone Daniel Barkalow
2008-02-26 18:53     ` Kristian Høgsberg
2008-03-02  5:57     ` [PATCH] builtin-clone: create remotes/origin/HEAD symref, if guessed Johannes Schindelin
2008-03-02  6:25       ` [PATCH, fixed] " Johannes Schindelin
2008-03-02  7:46         ` [PATCH] builtin clone: support bundles Johannes Schindelin
2008-03-02 16:19           ` Daniel Barkalow
2008-03-03  0:04             ` Santi Béjar
2008-03-02 16:48           ` Daniel Barkalow
2008-03-02 17:34             ` Johannes Schindelin
2008-03-02 17:50               ` Junio C Hamano
2008-03-02 17:54                 ` Junio C Hamano
2008-03-03  9:04             ` Johan Herland [this message]
2008-03-03 16:36               ` [PATCH] Add test for cloning with "--reference" repo being a subset of source repo Daniel Barkalow
2008-03-03 18:21               ` Daniel Barkalow
2008-03-04  3:02                 ` Johan Herland
2008-03-04  3:04                   ` [PATCH 1/2] Add test illustrating issues with sha1_file_name() and switching repos Johan Herland
2008-03-04  3:05                   ` [PATCH 2/2] Overly simplistic fix for issue " Johan Herland
2008-03-04 23:10                   ` [PATCH] Add test for cloning with "--reference" repo being a subset of source repo Daniel Barkalow
2008-03-05  0:24                     ` Daniel Barkalow
2008-03-05 23:56                       ` Johan Herland
2008-03-03 17:05         ` [PATCH, fixed] builtin-clone: create remotes/origin/HEAD symref, if guessed Kristian Høgsberg
2008-03-03 17:09           ` Pierre Habouzit
2008-03-03 19:55             ` Johannes Schindelin
2008-03-03 17:10           ` Johannes Schindelin
2008-03-03 17:41           ` Johan Herland
  -- strict thread matches above, loose matches on Subject: below --
2008-05-22 22:03 [PATCH] Add test for cloning with "--reference" repo being a subset of source repo Daniel Barkalow
2008-05-22 22:31 ` Johan Herland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803031004.16568.johan@herland.net \
    --to=johan@herland.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=barkalow@iabervon.org \
    --cc=git@vger.kernel.org \
    --cc=krh@redhat.com \
    --cc=sbejar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).