From: mkoegler@auto.tuwien.ac.at (Martin Koegler)
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: Header files not mentioned in the makefile
Date: Mon, 3 Mar 2008 19:55:24 +0100 [thread overview]
Message-ID: <20080303185524.GA26790@auto.tuwien.ac.at> (raw)
In-Reply-To: <alpine.LSU.1.00.0803031146310.22527@racer.site>
On Mon, Mar 03, 2008 at 11:47:01AM +0000, Johannes Schindelin wrote:
> On Mon, 3 Mar 2008, Martin Koegler wrote:
>
> > When I modified fetch-pack.h I was surprised by the fact, that it does
> > not result in rebuilding all object files. In fact, no file was rebuilt.
> > It turned out, that fetch-pack.h was not mentioned in the Makefile.
> >
> > A quick search (on next) showed, that other header files are also not
> > taking part in dependency checking:
> >
> > $for a in `ls *.h`; do grep "$a" Makefile >/dev/null || (echo "missing: $a"; grep "$a" *.c|grep include) ; done
> > missing: branch.h
>
> Somehow I miss "wt-status.h" in your list.
There is a dependency for wt-status.h, so it does not show up in
my grep:
builtin-revert.o wt-status.o: wt-status.h
But this is complete:
$ grep wt-status.h *.c
builtin-commit.c:#include "wt-status.h"
builtin-revert.c:#include "wt-status.h"
wt-status.c:#include "wt-status.h"
mfg Martin Kögler
next prev parent reply other threads:[~2008-03-03 18:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-03 7:24 Header files not mentioned in the makefile Martin Koegler
2008-03-03 11:47 ` Johannes Schindelin
2008-03-03 18:55 ` Martin Koegler [this message]
2008-03-03 19:22 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080303185524.GA26790@auto.tuwien.ac.at \
--to=mkoegler@auto.tuwien.ac.at \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).