git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Riesen <raa.lkml@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <junkio@cox.net>
Subject: [PATCH] Fix test for cleanup failure in t7300 on Windows
Date: Tue, 4 Mar 2008 00:48:56 +0100	[thread overview]
Message-ID: <20080303234856.GB28158@steel.home> (raw)
In-Reply-To: <20080226202227.GA1245@steel.home>

Keep the file open to: the OS does not allow removal of open files.
The saner systems just have a saner permission model and chmod 0
is enough for the test.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
Alex Riesen, Tue, Feb 26, 2008 21:22:27 +0100:
> Just a heads-up.
> 
> The test is fails because it uses "chmod 0" to enforce an error while
> deleting files by "git clean -f -d". This does not work on windows,
> because the directories even without write permission on them can be
> freely modified (the contained names can be removed). Maybe even the
> removal of list permission does not mean a thing either to cygwin or
> windows (that last one being more likely the case: it is more wrong).
> 
> So git-clean succeeds and the test fails.
> 
> It probably can be worked around by opening the file and keeping it open.
> 
> The patch below may fix it (haven't tested yet).
> 

It is tested now.

 t/t7300-clean.sh |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/t/t7300-clean.sh b/t/t7300-clean.sh
index 3840364..4037142 100755
--- a/t/t7300-clean.sh
+++ b/t/t7300-clean.sh
@@ -320,8 +320,9 @@ test_expect_success 'removal failure' '
 
 	mkdir foo &&
 	touch foo/bar &&
+	exec <foo/bar &&
 	chmod 0 foo &&
-	! git clean -f -d
+	test_must_fail git clean -f -d
 
 '
 chmod 755 foo
-- 
1.5.4.3.469.gf84e2


      reply	other threads:[~2008-03-03 23:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-26 20:22 t7300 "removal failure" broken on Windows Alex Riesen
2008-03-03 23:48 ` Alex Riesen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080303234856.GB28158@steel.home \
    --to=raa.lkml@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).