From: "Shawn O. Pearce" <spearce@spearce.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v2 3/3] Teach git-fetch to exploit server side automatic tag following
Date: Wed, 5 Mar 2008 00:56:59 -0500 [thread overview]
Message-ID: <20080305055659.GD8410@spearce.org> (raw)
In-Reply-To: <alpine.LSU.1.00.0803041512040.22527@racer.site>
Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> just two comments from me for this patch series:
>
> - it's a beaut, and
Thanks.
> - should followtags not be the default?
No. Absolutely not.
The client may not want tag objects from this remote. It might not
want those tags for all sorts of reasons. Maybe they are doing a
one-shot pull. Maybe they don't trust this remote. Maybe they trust
this remote but this remote is famous for 192M tags containing PDFs
of photo images of build logs printed out on paper, then photographed
on a wood table and finally scanned in at 600 dpi.
So it should only be enabled *if* we were willing to open a second
connection to this remote to followtags from it. And that's not
a change from prior behavior either, its just faster.
--
Shawn.
next prev parent reply other threads:[~2008-03-05 5:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 3:27 [PATCH v2 3/3] Teach git-fetch to exploit server side automatic tag following Shawn O. Pearce
2008-03-04 15:12 ` Johannes Schindelin
2008-03-05 5:56 ` Shawn O. Pearce [this message]
2008-03-05 11:21 ` Johannes Schindelin
2008-03-06 4:53 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080305055659.GD8410@spearce.org \
--to=spearce@spearce.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).