From: Pekka Kaitaniemi <kaitanie@cc.helsinki.fi>
To: paulus@samba.org, newsletter@dirk.my1.cc
Cc: git@vger.kernel.org
Subject: [PATCH] gitk: Add horizontal scrollbar to the diff view
Date: Thu, 6 Mar 2008 00:51:23 +0200 [thread overview]
Message-ID: <20080305225123.GA8485@localdomain> (raw)
Adding horizontal scroll bar makes the scrolling feature more
discoverable to the users.
Signed-off-by: Pekka Kaitaniemi <kaitanie@cc.helsinki.fi>
---
Here is a patch that adds horizontal scroll bar to the gitk diff
pane. It makes the scrolling feature a bit more discoverable and
accessible. The only downside is that it uses some screen real estate.
gitk | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/gitk b/gitk
index f1f21e9..817e0ce 100755
--- a/gitk
+++ b/gitk
@@ -857,14 +857,17 @@ proc makewindow {} {
set ctext .bleft.ctext
text $ctext -background $bgcolor -foreground $fgcolor \
-state disabled -font textfont \
- -yscrollcommand scrolltext -wrap none
+ -yscrollcommand scrolltext -wrap none \
+ -xscrollcommand ".bleft.sbhorizontal set"
if {$have_tk85} {
$ctext conf -tabstyle wordprocessor
}
scrollbar .bleft.sb -command "$ctext yview"
+ scrollbar .bleft.sbhorizontal -command "$ctext xview" -orient h
pack .bleft.top -side top -fill x
pack .bleft.mid -side top -fill x
pack .bleft.sb -side right -fill y
+ pack .bleft.sbhorizontal -side bottom -fill x -in .bleft
pack $ctext -side left -fill both -expand 1
lappend bglist $ctext
lappend fglist $ctext
--
1.5.4.3
next reply other threads:[~2008-03-05 22:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-05 22:51 Pekka Kaitaniemi [this message]
2008-03-06 6:18 ` [PATCH] gitk: Add horizontal scrollbar to the diff view Junio C Hamano
2008-03-06 10:30 ` Paul Mackerras
2008-03-06 11:53 ` Pekka Kaitaniemi
2008-03-08 1:53 ` Shawn O. Pearce
2008-03-08 5:41 ` Paul Mackerras
2008-03-08 5:51 ` Shawn O. Pearce
-- strict thread matches above, loose matches on Subject: below --
2008-03-08 12:27 Pekka Kaitaniemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080305225123.GA8485@localdomain \
--to=kaitanie@cc.helsinki.fi \
--cc=git@vger.kernel.org \
--cc=newsletter@dirk.my1.cc \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).