From: Johan Herland <johan@herland.net>
To: git@vger.kernel.org
Cc: "Daniel Barkalow" <barkalow@iabervon.org>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Kristian Høgsberg" <krh@redhat.com>,
"Santi Béjar" <sbejar@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Linus Torvalds" <torvalds@linux-foundation.org>
Subject: Re: [PATCH] Add test for cloning with "--reference" repo being a subset of source repo
Date: Thu, 06 Mar 2008 00:56:27 +0100 [thread overview]
Message-ID: <200803060056.27288.johan@herland.net> (raw)
In-Reply-To: <alpine.LNX.1.00.0803041922090.19665@iabervon.org>
On Wednesday 05 March 2008, Daniel Barkalow wrote:
> On Tue, 4 Mar 2008, Daniel Barkalow wrote:
> > I think we should be able to avoid setting git_dir to anything other than
> > the repo we're creating, which would avoid this problem for the present,
> > although, as you say, it would be good to be able to switch around as
> > instructed for libification purposes eventually.
>
> Okay, stuff pushed out to not use git_dir to access the reference repo,
> and an additional test that requires that we actually note that we have
> the refs in the reference repository (because otherwise we could pass all
> the tests by just making --reference useless, but that's obviously no
> good).
Thanks. Nice work. The testsuite passes, and it all looks good from here. :)
...Johan
--
Johan Herland, <johan@herland.net>
www.herland.net
next prev parent reply other threads:[~2008-03-05 23:57 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-25 21:12 [RFC] Build in clone Daniel Barkalow
2008-02-26 2:21 ` Johan Herland
2008-02-26 11:14 ` Johannes Schindelin
2008-02-26 12:19 ` Johan Herland
2008-02-26 12:58 ` Johan Herland
2008-02-26 13:37 ` Johan Herland
2008-02-26 15:35 ` [PATCH] Fix premature free of ref_lists while writing temporary refs to file Johan Herland
2008-02-26 15:42 ` Johannes Schindelin
2008-02-26 17:17 ` Johan Herland
2008-02-26 23:07 ` Daniel Barkalow
2008-02-26 23:11 ` Johan Herland
2008-02-26 15:40 ` [PATCH] Fix premature call to git_config() causing t1020-subdirectory to fail Johan Herland
2008-02-26 15:47 ` Johannes Schindelin
2008-02-26 22:12 ` Daniel Barkalow
2008-02-26 22:40 ` Johannes Schindelin
2008-02-26 22:49 ` Daniel Barkalow
2008-02-27 0:20 ` Junio C Hamano
2008-02-27 0:53 ` Daniel Barkalow
2008-02-27 1:34 ` Junio C Hamano
2008-02-27 19:47 ` Daniel Barkalow
2008-02-27 20:09 ` Junio C Hamano
2008-02-27 20:31 ` Daniel Barkalow
2008-02-26 17:36 ` [RFC] Build in clone Daniel Barkalow
2008-02-26 18:53 ` Kristian Høgsberg
2008-03-02 5:57 ` [PATCH] builtin-clone: create remotes/origin/HEAD symref, if guessed Johannes Schindelin
2008-03-02 6:25 ` [PATCH, fixed] " Johannes Schindelin
2008-03-02 7:46 ` [PATCH] builtin clone: support bundles Johannes Schindelin
2008-03-02 16:19 ` Daniel Barkalow
2008-03-03 0:04 ` Santi Béjar
2008-03-02 16:48 ` Daniel Barkalow
2008-03-02 17:34 ` Johannes Schindelin
2008-03-02 17:50 ` Junio C Hamano
2008-03-02 17:54 ` Junio C Hamano
2008-03-03 9:04 ` [PATCH] Add test for cloning with "--reference" repo being a subset of source repo Johan Herland
2008-03-03 16:36 ` Daniel Barkalow
2008-03-03 18:21 ` Daniel Barkalow
2008-03-04 3:02 ` Johan Herland
2008-03-04 3:04 ` [PATCH 1/2] Add test illustrating issues with sha1_file_name() and switching repos Johan Herland
2008-03-04 3:05 ` [PATCH 2/2] Overly simplistic fix for issue " Johan Herland
2008-03-04 23:10 ` [PATCH] Add test for cloning with "--reference" repo being a subset of source repo Daniel Barkalow
2008-03-05 0:24 ` Daniel Barkalow
2008-03-05 23:56 ` Johan Herland [this message]
2008-03-03 17:05 ` [PATCH, fixed] builtin-clone: create remotes/origin/HEAD symref, if guessed Kristian Høgsberg
2008-03-03 17:09 ` Pierre Habouzit
2008-03-03 19:55 ` Johannes Schindelin
2008-03-03 17:10 ` Johannes Schindelin
2008-03-03 17:41 ` Johan Herland
-- strict thread matches above, loose matches on Subject: below --
2008-05-22 22:03 [PATCH] Add test for cloning with "--reference" repo being a subset of source repo Daniel Barkalow
2008-05-22 22:31 ` Johan Herland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803060056.27288.johan@herland.net \
--to=johan@herland.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=krh@redhat.com \
--cc=sbejar@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).