From: Dmitry Potapov <dpotapov@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Pierre Habouzit <madcoder@debian.org>, Git ML <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] renaming quote_path() as quote_path_relative()
Date: Fri, 7 Mar 2008 05:19:38 +0300 [thread overview]
Message-ID: <20080307021938.GA5305@dpotapov.dyndns.org> (raw)
In-Reply-To: <7vve3z5mzh.fsf@gitster.siamese.dyndns.org>
On Thu, Mar 06, 2008 at 05:41:54PM -0800, Junio C Hamano wrote:
>
> Hmmm. Shouldn't the whole path (including the ../ part you add) be
> surrounded by a pair of dq iff quote_c_style() finds that the path needs
> to be quoted?
>
Yes, I think it is better, and especially so for git-clean output.
I will resend the patch.
Dmitry
prev parent reply other threads:[~2008-03-07 2:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-06 17:43 [PATCH v3] git-clean: correct printing relative path Dmitry Potapov
2008-03-06 23:08 ` Junio C Hamano
2008-03-07 1:13 ` [PATCH 1/2] renaming quote_path() as quote_path_relative() Dmitry Potapov
2008-03-07 1:13 ` [PATCH 2/2] git-clean: correct printing relative path Dmitry Potapov
2008-03-07 1:41 ` [PATCH 1/2] renaming quote_path() as quote_path_relative() Junio C Hamano
2008-03-07 2:19 ` Dmitry Potapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080307021938.GA5305@dpotapov.dyndns.org \
--to=dpotapov@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=madcoder@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).