git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: Imran M Yousuf <imyousuf@gmail.com>,
	git@vger.kernel.org, Dave Watson <dwatson@mimvista.com>,
	"Roger C. Soares" <rogersoares@intelinet.com.br>
Subject: Re: [jgit] index v2 pull request
Date: Wed, 12 Mar 2008 03:52:05 -0400	[thread overview]
Message-ID: <20080312075205.GT8410@spearce.org> (raw)
In-Reply-To: <200803120807.01715.robin.rosenberg@dewire.com>

Robin Rosenberg <robin.rosenberg@dewire.com> wrote:
> Den Wednesday 12 March 2008 03.52.05 skrev Imran M Yousuf:
> 
> > I am currently looking into .git/config format as Shawn suggested.
> 
> That's a good one too. I have code for parsing the remotes specs, though
> e.g. "+refs/heads/master/*:refs/remotes/origin/*", but nothing for the "branch" config. I haven't used it yet, so it's a rip-out.	

Your RemoteSpec is missing the fact that some people have more than
one URL, fetch, and/or push lines in the same remote.  :-)
 
> + * <pre>
> + *  [remote &quot;name&quot;]
> + *     url = URL:ish
> + *     fetch = [+]remoteref:localref
> + * </pre>
> + *
> + * There are more variants but we do not support them here yet.

Or is that what you mean by the above statement?

In any case the remote spec needs a list of URLs a list of the
fetch/push Info objects.  That changes the public API of the
RemoteSpec class rather significantly.

> +public class RemoteSpec {
> +
> +	static class Info {
> +		boolean overwriteAlways;
> +
> +		boolean matchAny;
> +
> +		String remoteRef;
> +
> +		String localRef;
> +	}
> +
> +	Info fetch = new Info();
> +
> +	Info push = null;
> +
> +	private final String name;
> +
> +	private final String url;

-- 
Shawn.

  reply	other threads:[~2008-03-12  7:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-08  2:50 [jgit] index v2 pull request Shawn O. Pearce
2008-03-08  9:08 ` Jakub Narebski
2008-03-09  0:51   ` Shawn O. Pearce
2008-03-09 23:51 ` Robin Rosenberg
2008-03-10  7:32   ` Imran M Yousuf
2008-03-10 21:53     ` Robin Rosenberg
2008-03-12  2:52       ` Imran M Yousuf
2008-03-12  7:07         ` Robin Rosenberg
2008-03-12  7:52           ` Shawn O. Pearce [this message]
2008-03-12  8:19           ` Imran M Yousuf
2008-03-11  0:35     ` Shawn O. Pearce
2008-03-11  2:24       ` Imran M Yousuf
2008-03-10 23:31   ` Shawn O. Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080312075205.GT8410@spearce.org \
    --to=spearce@spearce.org \
    --cc=dwatson@mimvista.com \
    --cc=git@vger.kernel.org \
    --cc=imyousuf@gmail.com \
    --cc=robin.rosenberg@dewire.com \
    --cc=rogersoares@intelinet.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).