git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Should 'git config' support key with dot such as 'a.b'
@ 2008-03-14  8:24 Ping Yin
  2008-03-14 10:39 ` Johannes Schindelin
  2008-03-17  1:00 ` Xavier Maillard
  0 siblings, 2 replies; 7+ messages in thread
From: Ping Yin @ 2008-03-14  8:24 UTC (permalink / raw)
  To: Git Mailing List

I find it is so annoying to write submodule definition as follows
(yeah, only url, without path)

------------------------------
[submodule 'crawler']
    url = url1
[submodule 'search']
    url = url2
------------------------------

I think the following form is more simple
---------------------------------
[submodule]
     crawler.url = url1
     search.url = url2
---------------------------------

So, could we support such simpler form?


-- 
Ping Yin

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Should 'git config' support key with dot such as 'a.b'
  2008-03-14  8:24 Should 'git config' support key with dot such as 'a.b' Ping Yin
@ 2008-03-14 10:39 ` Johannes Schindelin
  2008-03-18  0:40   ` Ping Yin
  2008-03-17  1:00 ` Xavier Maillard
  1 sibling, 1 reply; 7+ messages in thread
From: Johannes Schindelin @ 2008-03-14 10:39 UTC (permalink / raw)
  To: Ping Yin; +Cc: Git Mailing List

Hi,

On Fri, 14 Mar 2008, Ping Yin wrote:

> I find it is so annoying to write submodule definition as follows
> (yeah, only url, without path)
> 
> ------------------------------
> [submodule 'crawler']
>     url = url1
> [submodule 'search']
>     url = url2
> ------------------------------
> 
> I think the following form is more simple
> ---------------------------------
> [submodule]
>      crawler.url = url1
>      search.url = url2
> ---------------------------------
> 
> So, could we support such simpler form?

I don't like it at all.  Historically, we had much stricter rules on the 
variable names than the second part of the section names.

Also, your suggestion would make things even more confusing than beginners 
already complain Git is.

Ciao,
Dscho

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Should 'git config' support key with dot such as 'a.b'
  2008-03-14  8:24 Should 'git config' support key with dot such as 'a.b' Ping Yin
  2008-03-14 10:39 ` Johannes Schindelin
@ 2008-03-17  1:00 ` Xavier Maillard
  2008-03-17  8:48   ` Frank Lichtenheld
  1 sibling, 1 reply; 7+ messages in thread
From: Xavier Maillard @ 2008-03-17  1:00 UTC (permalink / raw)
  To: Ping Yin; +Cc: git



   I think the following form is more simple
   ---------------------------------
   [submodule]
	crawler.url = url1
	search.url = url2
   ---------------------------------

   So, could we support such simpler form?

Dunno if my vote will count but I really don't like your
proposition. I find clearer with the current notation. What's
more it forces people to be more rigorous when touching their
configuration file.

git config is really simple to use and there should not be
difficult for anybody (even new git users) to set up git using
this helper tool. We should not recommend beginners to manually
edit their .git/config file when git-config could be used.

	Xavier
-- 
http://www.gnu.org
http://www.april.org
http://www.lolica.org

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Should 'git config' support key with dot such as 'a.b'
  2008-03-17  1:00 ` Xavier Maillard
@ 2008-03-17  8:48   ` Frank Lichtenheld
  2008-03-17  9:03     ` Frank Lichtenheld
  0 siblings, 1 reply; 7+ messages in thread
From: Frank Lichtenheld @ 2008-03-17  8:48 UTC (permalink / raw)
  To: Xavier Maillard; +Cc: Ping Yin, git

On Mon, Mar 17, 2008 at 02:00:03AM +0100, Xavier Maillard wrote:
>    I think the following form is more simple
>    ---------------------------------
>    [submodule]
> 	crawler.url = url1
> 	search.url = url2
>    ---------------------------------
> 
>    So, could we support such simpler form?
> 
> Dunno if my vote will count but I really don't like your
> proposition. I find clearer with the current notation. What's
> more it forces people to be more rigorous when touching their
> configuration file.
> 
> git config is really simple to use and there should not be
> difficult for anybody (even new git users) to set up git using
> this helper tool. We should not recommend beginners to manually
> edit their .git/config file when git-config could be used.

git config hasn't exactly a excellent track-record for dealing with all
the possibilities the config syntax allows. Adding yet another
possibility will not make it any more reliable.

Also your argument that people should git-config anyway instead of
editing by hand kinda contradicts the need for a new format, since
it would change anything for the git-config interface, only for people
editing the file by hand...

At the end of the day I don't think the benefits justify the effort.

Gruesse,
-- 
Frank Lichtenheld <frank@lichtenheld.de>
www: http://www.djpig.de/

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Should 'git config' support key with dot such as 'a.b'
  2008-03-17  8:48   ` Frank Lichtenheld
@ 2008-03-17  9:03     ` Frank Lichtenheld
  0 siblings, 0 replies; 7+ messages in thread
From: Frank Lichtenheld @ 2008-03-17  9:03 UTC (permalink / raw)
  To: Xavier Maillard; +Cc: Ping Yin, git

Bah, I really should be awake by now...

On Mon, Mar 17, 2008 at 09:48:15AM +0100, Frank Lichtenheld wrote:
> On Mon, Mar 17, 2008 at 02:00:03AM +0100, Xavier Maillard wrote:
> Also your argument that people should git-config anyway instead of

s/should/should use/

> editing by hand kinda contradicts the need for a new format, since
> it would change anything for the git-config interface, only for people

s/would/would not/

> editing the file by hand...
> 
> At the end of the day I don't think the benefits justify the effort.

Gruesse,
-- 
Frank Lichtenheld <frank@lichtenheld.de>
www: http://www.djpig.de/

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Should 'git config' support key with dot such as 'a.b'
  2008-03-14 10:39 ` Johannes Schindelin
@ 2008-03-18  0:40   ` Ping Yin
  2008-03-18  0:42     ` Junio C Hamano
  0 siblings, 1 reply; 7+ messages in thread
From: Ping Yin @ 2008-03-18  0:40 UTC (permalink / raw)
  To: Johannes Schindelin; +Cc: Git Mailing List

On Fri, Mar 14, 2008 at 6:39 PM, Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
>
>
>  On Fri, 14 Mar 2008, Ping Yin wrote:
>
>  > I find it is so annoying to write submodule definition as follows
>  > (yeah, only url, without path)
>  >
>  > ------------------------------
>  > [submodule 'crawler']
>  >     url = url1
>  > [submodule 'search']
>  >     url = url2
>  > ------------------------------
>  >
>  > I think the following form is more simple
>  > ---------------------------------
>  > [submodule]
>  >      crawler.url = url1
>  >      search.url = url2
>  > ---------------------------------
>  >
>  > So, could we support such simpler form?
>
>  I don't like it at all.  Historically, we had much stricter rules on the
>  variable names than the second part of the section names.
>
>  Also, your suggestion would make things even more confusing than beginners
>  already complain Git is.
>

Beginners will not edit config file directly. If they do, they can
follow the usaual syntax. So beginners don't have to know the new
syntax.

But for advanced users, the config file can be edited freely with more
free syntax. With current syntax, 'submodule'  will be repeated tons
of times when having tons of submoudles. Why not make life much easier
for advanced users in such case?



-- 
Ping Yin

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Should 'git config' support key with dot such as 'a.b'
  2008-03-18  0:40   ` Ping Yin
@ 2008-03-18  0:42     ` Junio C Hamano
  0 siblings, 0 replies; 7+ messages in thread
From: Junio C Hamano @ 2008-03-18  0:42 UTC (permalink / raw)
  To: Ping Yin; +Cc: Johannes Schindelin, Git Mailing List

"Ping Yin" <pkufranky@gmail.com> writes:

> On Fri, Mar 14, 2008 at 6:39 PM, Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
>> Hi,
>>
>>
>>
>>  On Fri, 14 Mar 2008, Ping Yin wrote:
>>
>>  > I find it is so annoying to write submodule definition as follows
>>  > (yeah, only url, without path)
>>  >
>>  > ------------------------------
>>  > [submodule 'crawler']
>>  >     url = url1
>>  > [submodule 'search']
>>  >     url = url2
>>  > ------------------------------
>>  >
>>  > I think the following form is more simple
>>  > ---------------------------------
>>  > [submodule]
>>  >      crawler.url = url1
>>  >      search.url = url2
>>  > ---------------------------------
>>  >
>>  > So, could we support such simpler form?
>>
>>  I don't like it at all.  Historically, we had much stricter rules on the
>>  variable names than the second part of the section names.
>>
>>  Also, your suggestion would make things even more confusing than beginners
>>  already complain Git is.

I am not interested in this at all.  I would usually say "it is not clear
what advantage this has", but in this case, I would rather say "it is
clear there is no advantage in this".

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2008-03-18  0:43 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-14  8:24 Should 'git config' support key with dot such as 'a.b' Ping Yin
2008-03-14 10:39 ` Johannes Schindelin
2008-03-18  0:40   ` Ping Yin
2008-03-18  0:42     ` Junio C Hamano
2008-03-17  1:00 ` Xavier Maillard
2008-03-17  8:48   ` Frank Lichtenheld
2008-03-17  9:03     ` Frank Lichtenheld

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).