git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonas Fonseca <fonseca@diku.dk>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [ANNOUNCE] tig-0.10
Date: Mon, 17 Mar 2008 12:28:25 +0100	[thread overview]
Message-ID: <20080317112825.GA12798@diku.dk> (raw)
In-Reply-To: <7vlk4hbp64.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> wrote Mon, Mar 17, 2008:
> Jonas Fonseca <fonseca@diku.dk> writes:
> > I am not sure I understand. As far as I know, tig does not require
> > autoreconf unless you have cloned the repository and want to bootstrap
> > the configure script.
> 
> Yeah, but that was exactly what your announcement suggested to.  Show
> Tarball and Gitfeed alternatives to a git person, who already has a clone
> of the project, and guess which one he would go ;-).
> 
> Also INSTALL file begins with:
> 
> [...]

Ok, I will try to make it more clear that usage of configure (and
autoreconf) is optional.

> By the way, it would be nice if someday I can get tig work with CJK.
> Perhaps I need to tweak something in ncurses?

I will make it a priority to fix this shortcoming. Until then you can
improve the situation by linking with the ncursesw library. At least the
diff view and names in the commit listing will be properly displayed.

diff --git a/Makefile b/Makefile
index 575c5bf..e57ae6a 100644
--- a/Makefile
+++ b/Makefile
@@ -32,7 +32,7 @@ RPM_VERLIST = $(filter-out g% dirty,$(subst -, ,$(VERSION))) 0
 RPM_VERSION = $(word 1,$(RPM_VERLIST))
 RPM_RELEASE = $(word 2,$(RPM_VERLIST))$(if $(WTDIRTY),.dirty)
 
-LDLIBS ?= -lcurses
+LDLIBS ?= -lncursesw
 CFLAGS ?= -Wall -O2
 DFLAGS	= -g -DDEBUG -Werror
 PROGS	= tig

-- 
Jonas Fonseca

  reply	other threads:[~2008-03-17 11:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-17  2:03 [ANNOUNCE] tig-0.10 Jonas Fonseca
2008-03-17  8:25 ` Junio C Hamano
2008-03-17 10:23   ` Jonas Fonseca
2008-03-17 10:49     ` Junio C Hamano
2008-03-17 11:28       ` Jonas Fonseca [this message]
2008-03-17  9:45 ` Jakub Narebski
2008-03-17 10:27   ` Jonas Fonseca
2008-03-19 23:33 ` [ANNOUNCE] tig-0.10.1 Jonas Fonseca
2008-03-20  0:52   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080317112825.GA12798@diku.dk \
    --to=fonseca@diku.dk \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).