From: Frank Lichtenheld <frank@lichtenheld.de>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org, Petr Baudis <pasky@suse.cz>,
"J.H." <warthog19@eaglescrag.net>
Subject: Re: [RFC/PATCH 2/3] gitweb: Support caching projects list
Date: Mon, 17 Mar 2008 20:10:29 +0100 [thread overview]
Message-ID: <20080317191029.GE18624@mail-vs.djpig.de> (raw)
In-Reply-To: <200803171952.15186.jnareb@gmail.com>
On Mon, Mar 17, 2008 at 07:52:13PM +0100, Jakub Narebski wrote:
> Dnia poniedziałek 17. marca 2008 17:54, Frank Lichtenheld napisał:
>
> >At the very least you should:
> [...]
> > - Check if the file is owned by the uid gitweb is running under and
> > not word-writable.
>
> UID ($>) or PID ($$) should be equal to cache owner: stat($file)->uid?
I'm not sure what the PID has to do with anything here?
But yeah, $> was what I meant.
(Although I actually prefer to use POSIX::geteuid instead, since I can
understand that faster).
Gruesse,
--
Frank Lichtenheld <frank@lichtenheld.de>
www: http://www.djpig.de/
next prev parent reply other threads:[~2008-03-17 19:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-17 15:09 [PATCH 0/3 v2] gitweb: Support caching projects list Jakub Narebski
2008-03-17 15:09 ` [PATCH 1/3] gitweb: Separate @projects population into git_get_projects_details() Jakub Narebski
2008-03-17 15:09 ` [RFC/PATCH 2/3] gitweb: Support caching projects list Jakub Narebski
2008-03-17 16:54 ` Frank Lichtenheld
2008-03-17 18:52 ` Jakub Narebski
2008-03-17 19:10 ` Frank Lichtenheld [this message]
2008-03-17 20:25 ` Jakub Narebski
2008-03-17 15:09 ` [RFC/PATCH 3/3] gitweb: Fill project details lazily when caching Jakub Narebski
2008-03-18 3:14 ` Petr Baudis
2008-03-18 9:12 ` Jakub Narebski
2008-03-18 9:52 ` Frank Lichtenheld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080317191029.GE18624@mail-vs.djpig.de \
--to=frank@lichtenheld.de \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=pasky@suse.cz \
--cc=warthog19@eaglescrag.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).