git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Teemu Likonen <tlikonen@iki.fi>
To: git@vger.kernel.org
Cc: Brandon Casey <casey@nrlssc.navy.mil>,
	Nicolas Pitre <nico@cam.org>, Jens Axboe <jens.axboe@oracle.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] builtin-gc.c: allow disabling all auto-gc'ing by assigning 0 to gc.auto
Date: Thu, 20 Mar 2008 09:08:13 +0200	[thread overview]
Message-ID: <200803200908.14061.tlikonen@iki.fi> (raw)
In-Reply-To: <47E18B50.2080402@nrlssc.navy.mil>

Brandon Casey kirjoitti:

> The gc.auto configuration variable is somewhat ambiguous now that
> there is also a gc.autopacklimit setting. Some users may assume that
> it controls all auto-gc'ing. Also, now users must set two
> configuration variables to zero when they want to disable
> autopacking. Since it is unlikely that users will want to autopack
> based on some threshold of pack files when they have disabled
> autopacking based on the number of loose objects, be nice and allow a
> setting of zero for gc.auto to disable all autopacking.
>
> Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
> ---
>  builtin-gc.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)

This change should be documented in the git-gc.txt and config.txt. For 
example, the former currently says:

"Housekeeping is required if there are too many loose objects or too 
many packs in the repository. [...] Setting the value of `gc.auto` to 0 
disables automatic packing of loose objects."

So, from the git-gc.txt's (current) point of view, gc.auto=0 does not 
touch the "or too many packs" part.

  reply	other threads:[~2008-03-20  7:09 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-18 18:01 auto gc again Jens Axboe
2008-03-18 18:14 ` Linus Torvalds
2008-03-18 18:19   ` Jens Axboe
2008-03-18 18:24     ` Jens Axboe
2008-03-18 18:33       ` Linus Torvalds
2008-03-18 18:39         ` Jens Axboe
2008-03-19 20:22           ` Johannes Schindelin
2008-03-19 21:14             ` Jens Axboe
2008-03-19 21:44               ` Johannes Schindelin
2008-03-20  6:00                 ` Jens Axboe
2008-03-19 20:37     ` Nicolas Pitre
2008-03-19 21:17       ` Jens Axboe
2008-03-19 23:05         ` Nicolas Pitre
2008-03-20  7:40           ` Jens Axboe
2008-03-20  7:55             ` Junio C Hamano
2008-03-20 17:31               ` Jens Axboe
2008-03-19 21:27       ` Brandon Casey
2008-03-19 21:53         ` [PATCH] builtin-gc.c: allow disabling all auto-gc'ing by assigning 0 to gc.auto Brandon Casey
2008-03-20  7:08           ` Teemu Likonen [this message]
2008-03-19 22:56         ` auto gc again Nicolas Pitre
2008-03-20  6:01         ` Jens Axboe
2008-03-19 21:27 ` Junio C Hamano
2008-03-19 21:52   ` Linus Torvalds
2008-03-19 22:28     ` Junio C Hamano
2008-03-19 23:16       ` Nicolas Pitre
2008-03-19 23:25         ` Junio C Hamano
2008-03-20  3:13           ` Nicolas Pitre
2008-03-20  4:09             ` Junio C Hamano
2008-03-20  4:40               ` Nicolas Pitre
2008-03-20  4:49                 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803200908.14061.tlikonen@iki.fi \
    --to=tlikonen@iki.fi \
    --cc=casey@nrlssc.navy.mil \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jens.axboe@oracle.com \
    --cc=nico@cam.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).