git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jörg Sommer" <joerg@alea.gnuu.de>
To: git@vger.kernel.org
Cc: Johannes.Schindelin@gmx.de
Subject: Re: [PATCH] New test for preserve merges and squash
Date: Thu, 20 Mar 2008 11:18:09 +0100	[thread overview]
Message-ID: <20080320101809.GA23108@alea.gnuu.de> (raw)
In-Reply-To: <7v1w661bnx.fsf@gitster.siamese.dyndns.org>

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]

Hi,

Junio C Hamano schrieb am Wed 19. Mar, 17:28 (-0700):
> Jörg Sommer <joerg@alea.gnuu.de> writes:
> 
> > Signed-off-by: Jörg Sommer <joerg@alea.gnuu.de>
> > ---
> >  t/t3404-rebase-interactive.sh |   20 ++++++++++++++++++++
> >  1 files changed, 20 insertions(+), 0 deletions(-)
> >
> > The current version of git fails this test. I think it's a bug, because
> > the patch is what I expect to happen. Or am I wrong?
> 
> Please mark such tests with test_expect_fail.

No, I expect the test succeeds. Currently, it fails. This might be,
because my expectations are wrong or there's a bug.

> And also Cc: the guilty parties.

Okay, I've added Johannes the author of f09c9b8c5ff to the Cc: list.

Johannes, can you explain why this test fails?

Bye, Jörg.
-- 
> Definiere ‚Demokratie‘ …
… eine Mehrheit beweist einer Minderheit, dass Widerstand zwecklos ist.

[-- Attachment #2: Digital signature http://en.wikipedia.org/wiki/OpenPGP --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2008-03-20 10:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-20  0:03 [PATCH] New test for preserve merges and squash Jörg Sommer
2008-03-20  0:28 ` Junio C Hamano
2008-03-20 10:18   ` Jörg Sommer [this message]
2008-03-20 11:09     ` Johannes Schindelin
2008-03-20 13:01       ` [PATCH] New test for rebase with " Jörg Sommer
2008-03-20 23:46         ` Johannes Schindelin
2008-03-21 12:56           ` Why rebase with preserve merges asks for merged commits Jörg Sommer
2008-03-21 13:14             ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080320101809.GA23108@alea.gnuu.de \
    --to=joerg@alea.gnuu.de \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).