Re: [PATCH 1/2] help: use man viewer path from "man.<tool>.path" config var

[Christian Couder <chriscool@tuxfamily.org>]

Le jeudi 20 mars 2008, Junio C Hamano a écrit :
> Christian Couder <chriscool@tuxfamily.org> writes:
> > Yes, but if the user just wants to use a konq that is not in the path,
> > then the konq specified with "man.konqueror.path" should behave the
> > same as when using the konq in the path. That means that we should also
> > try to open a new tab on an existing konq, and this will not be the
> > case if we use "/path/konqueror URL" instead of "/path/kfmclient newTab
> > URL".
>
> If that inconsistency bothers you, you probably should rename the
> built-in konqueror support to "kfmclient", which is more honest approach,
> I would think.

It's perhaps more honest, but kfmclient is not as well known as konqueror.

Isn't a documentation patch like this enough:

------8<---------

diff --git a/Documentation/git-help.txt b/Documentation/git-help.txt
index 4c6cb21..0ece412 100644
--- a/Documentation/git-help.txt
+++ b/Documentation/git-help.txt
@@ -87,7 +87,8 @@ is chosen. Only the following values are currently 
supported:
 * "man": use the 'man' program as usual,
 * "woman": use 'emacsclient' to launch the "woman" mode in emacs
 (this only works starting with emacsclient versions 22),
-* "konqueror": use a man KIO slave in konqueror.
+* "konqueror": use kfmclient to open the man page in a new konqueror
+tab.

 Multiple values may be given to this configuration variable. Their
 corresponding programs will be tried in the order listed in the

------8<---------

I also wonder if you want some changes in "git-web--browse.sh" as there is 
the same logic ?

Thanks,
Christian.