git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jörg Sommer" <joerg@alea.gnuu.de>
To: git@vger.kernel.org
Cc: B.Steinbrink@gmx.de
Subject: Re: [PATCH 3/3] Improve failure test for preserve merges
Date: Sat, 22 Mar 2008 22:57:02 +0100	[thread overview]
Message-ID: <20080322215702.GA29174@alea.gnuu.de> (raw)
In-Reply-To: <1206222266-29179-3-git-send-email-joerg@alea.gnuu.de>

[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]

Jörg Sommer schrieb am Sat 22. Mar, 22:44 (+0100):
> 
> Signed-off-by: Jörg Sommer <joerg@alea.gnuu.de>
> ---
>  t/t3404-rebase-interactive.sh |   10 ++++++----
>  1 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh
> index 014b036..eaa2fc0 100755
> --- a/t/t3404-rebase-interactive.sh
> +++ b/t/t3404-rebase-interactive.sh
> @@ -213,11 +213,13 @@ test_expect_success 'preserve merges with -p' '
>  '
>  
>  test_expect_failure 'preserve merges with -p (case 2)' '

This test still fails, but I don't know how to fix it. The situation is
this:

o---P
 \   \
  A---M---B

A and B should get exchanged. So I would assume that telling rebase the
following should do it:

pick P
pick B
pick M
pick A

But what should be the new parent of B?

Is it allowed to permute lines with preserve merges? I've got the
impression it's not.

Bye, Jörg.
-- 
[dpkg] We are the apt. Resistance is futile. You will be packaged.

[-- Attachment #2: Digital signature http://en.wikipedia.org/wiki/OpenPGP --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

      reply	other threads:[~2008-03-22 22:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-22 21:44 [PATCH 1/3] Add test for rebase interactive with preserve merges Jörg Sommer
2008-03-22 21:44 ` [PATCH 2/3] Change rebase with preserver merges to pick up the right new HEAD Jörg Sommer
2008-03-22 21:44   ` [PATCH 3/3] Improve failure test for preserve merges Jörg Sommer
2008-03-22 21:57     ` Jörg Sommer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080322215702.GA29174@alea.gnuu.de \
    --to=joerg@alea.gnuu.de \
    --cc=B.Steinbrink@gmx.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).