git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Fix branches file configuration
@ 2008-03-25 23:35 Daniel Barkalow
  2008-03-25 23:50 ` Andrew Morton
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Daniel Barkalow @ 2008-03-25 23:35 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git, Andrew Morton

It turns out that .git/branches/foo should fetch into refs/heads/foo.

Signed-off-by: Daniel Barkalow <barkalow@iabervon.org>
---
We still don't have a test for that bit of the behavior, so I could have 
it still doing the wrong thing. But it at least should do what I think 
people want.

Andrew, could you give this a try, on top of current master (or, for that 
matter, any released version that doesn't work), and let me know if it 
does the wrong thing?

 remote.c |   15 +++++++--------
 1 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/remote.c b/remote.c
index 40ed246..a027bca 100644
--- a/remote.c
+++ b/remote.c
@@ -232,7 +232,7 @@ static void read_branches_file(struct remote *remote)
 {
 	const char *slash = strchr(remote->name, '/');
 	char *frag;
-	char *branch;
+	struct strbuf branch;
 	int n = slash ? slash - remote->name : 1000;
 	FILE *f = fopen(git_path("branches/%.*s", n, remote->name), "r");
 	char *s, *p;
@@ -258,17 +258,16 @@ static void read_branches_file(struct remote *remote)
 	strcpy(p, s);
 	if (slash)
 		strcat(p, slash);
+	strbuf_init(&branch, 0);
 	frag = strchr(p, '#');
 	if (frag) {
 		*(frag++) = '\0';
-		branch = xmalloc(strlen(frag) + 12);
-		strcpy(branch, "refs/heads/");
-		strcat(branch, frag);
-	} else {
-		branch = "refs/heads/master";
-	}
+		strbuf_addf(&branch, "refs/heads/%s", frag);
+	} else
+		strbuf_addstr(&branch, "refs/heads/master");
 	add_url_alias(remote, p);
-	add_fetch_refspec(remote, branch);
+	strbuf_addf(&branch, ":refs/heads/%s", remote->name);
+	add_fetch_refspec(remote, strbuf_detach(&branch, 0));
 	remote->fetch_tags = 1; /* always auto-follow */
 }
 
-- 
1.5.4.3.610.gea6cd

^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2008-03-26  8:34 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-25 23:35 [PATCH] Fix branches file configuration Daniel Barkalow
2008-03-25 23:50 ` Andrew Morton
2008-03-25 23:56 ` Junio C Hamano
2008-03-26  0:03   ` Andrew Morton
2008-03-26  6:51   ` Daniel Barkalow
2008-03-26  7:29     ` Junio C Hamano
2008-03-26  8:03       ` Junio C Hamano
2008-03-26  8:33 ` [PATCH] git-fetch test: test tracking fetch results, not just FETCH_HEAD Junio C Hamano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).