git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Teemu Likonen <tlikonen@iki.fi>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] send-email: rfc2047-quote subject lines with non-ascii characters
Date: Wed, 26 Mar 2008 05:33:10 -0400	[thread overview]
Message-ID: <20080326093310.GA937@coredump.intra.peff.net> (raw)
In-Reply-To: <20080326092303.GA17835@mithlond.arda.local>

On Wed, Mar 26, 2008 at 11:23:03AM +0200, Teemu Likonen wrote:

> Hmm, do you send the 0000-cover-letter.patch with 'git send-email'? It
> seems that this cover letter don't get MIME headers when sent that way.
> Sending through 'mutt -H' it works fine but then the Message-Id needs to
> be copy-pasted manually to send-mail for the rest of the series (to have
> them appear as replies, that is). No problem with that.

No, I have format-patch do the threading. So something like:

  git format-patch --cover-letter --thread --stdout upstream >mbox
  mutt -f mbox

and then in mutt I bind a key to <resend-message>. For each message, I
do the 'resend', set the recipient headers, look it over one last time,
and then send. The most annoying part is entering the recipients;
usually it isn't too bad because I have short aliases for Junio and the
list, but I had to, e.g., cut and paste your address twice for the other
series.

Probably munging the 'to:' and 'cc:' before running mutt would make the
most sense, but I haven't gotten around to it yet.

> I mostly use (and promote) UTF-8 and now that I begin to understand how
> send-email works I can live with the current behaviour just fine. Don't
> take my feedback as complaining. :)

OK, I am inclined to leave the patches as-is, then, and wait for
somebody to complain about their pet encoding. My reasoning is that:

  - in most cases throughout git, we assume things are happening in
    utf-8, so I don't think it will come as a great surprise
  - I think doing it right might be more complex than just send-mail; I
    am thinking there might need to be a "stuff the user inputs is in
    encoding X" config option. And I don't want to do the work. :)

> Thanks for your work on this. Really.

No problem at all. Thank you for helping make git better with bug
reports!

-Peff

  parent reply	other threads:[~2008-03-26  9:33 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <7caf19ae394accab538d2f94953bb62b55a2c79f.1206486012.git.peff@peff.net>
2008-03-25 23:03 ` [PATCH 2/2] send-email: rfc2047-quote subject lines with non-ascii characters Jeff King
2008-03-26  5:59   ` Teemu Likonen
2008-03-26  6:20     ` Jeff King
2008-03-26  8:30       ` Teemu Likonen
2008-03-26  8:39         ` Jeff King
2008-03-26  9:23           ` Teemu Likonen
2008-03-26  9:32             ` Teemu Likonen
2008-03-26  9:35               ` Jeff King
2008-03-26  9:33             ` Jeff King [this message]
2008-03-27  7:38               ` Jeff King
2008-03-27 19:44                 ` Todd Zullinger
2008-03-28 21:27 [ANNOUNCE] GIT 1.5.5-rc2 Jeff King
2008-03-28 21:29 ` [PATCH 2/2] send-email: rfc2047-quote subject lines with non-ascii characters Jeff King
2008-03-29  7:19   ` Robin Rosenberg
2008-03-29  7:22     ` Jeff King
2008-03-29  8:41       ` Robin Rosenberg
2008-03-29  8:49         ` Jeff King
2008-03-29  9:02           ` Robin Rosenberg
2008-03-29  9:11             ` Jeff King
2008-03-29  9:39               ` Robin Rosenberg
2008-03-29  9:43                 ` Jeff King
2008-03-29 12:54                   ` Robin Rosenberg
2008-03-29 21:45                     ` Jeff King
2008-03-30  3:40                       ` Sam Vilain
2008-03-30  4:39                         ` Jeff King
2008-03-30 23:47         ` Junio C Hamano
2008-03-29  8:44       ` Robin Rosenberg
2008-03-29  8:53         ` Jeff King
2008-03-29  9:38           ` Robin Rosenberg
2008-03-29  9:52             ` Jeff King
2008-03-29 12:54               ` Robin Rosenberg
2008-03-29 21:18                 ` Jeff King
2008-03-29 21:43                   ` Robin Rosenberg
2008-03-29 22:00                     ` Jeff King
2008-03-30  2:12               ` Sam Vilain
2008-03-30  4:31                 ` Jeff King
2008-05-21 19:39   ` Junio C Hamano
2008-05-21 19:47     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080326093310.GA937@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=tlikonen@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).