From: Jeff King <peff@peff.net>
To: Bernd Ahlers <bernd@ba-net.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Use 'grep -a' to fix some errors with non-GNU grep(1).
Date: Fri, 28 Mar 2008 20:49:08 -0400 [thread overview]
Message-ID: <20080329004908.GA9878@coredump.intra.peff.net> (raw)
In-Reply-To: <20080328224011.GB5486@dengar.tuneafish.de>
On Fri, Mar 28, 2008 at 11:40:11PM +0100, Bernd Ahlers wrote:
> This fixes test errors on OpenBSD.
Nak. "grep -a" isn't portable. If you have binary goo to check, I think
the safest thing is to either generate it using printf (if it's short
and easy) or include the expected output in a test file (this is what I
did for t4020; see 53a5b443).
You could also potentially use git-grep for this, but I haven't looked
into how it handles "-a" (and in general, I think we try to avoid using
git tools as test infrastructure to avoid false positives; e.g., we
prefer using a system tool to compare expected output rather than
git-diff).
-Peff
prev parent reply other threads:[~2008-03-29 0:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 22:40 [PATCH] Use 'grep -a' to fix some errors with non-GNU grep(1) Bernd Ahlers
2008-03-29 0:49 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080329004908.GA9878@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=bernd@ba-net.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).