From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Toby Corkindale <toby.corkindale@rea-group.com>, git@vger.kernel.org
Subject: Re: [BUG?] git-archive ignores remote .gitattributes (was: .git/info/attributes not cloned)
Date: Sun, 30 Mar 2008 22:47:55 -0400 [thread overview]
Message-ID: <20080331024755.GA690@coredump.intra.peff.net> (raw)
In-Reply-To: <alpine.LSU.1.00.0803281321260.18259@racer.site>
On Fri, Mar 28, 2008 at 01:22:53PM +0100, Johannes Schindelin wrote:
> > "git-archive --remote=/some/repo" will ignore /some/repo/.gitattributes,
> > but check /some/repo/info/attributes.
> >
> > I think the problem is in the loop that looks for .gitattributes, which
> > seems to do so by taking the current path and iterating down through it?
>
> The problem is that "git archive --remote" operates on the remote
> repository as if it were bare. Which in many cases is true.
>
> So I'd submit that this is not the usage .gitattributes is meant for, and
> that you should clone the thing if you want to generate archives heeding
> the .gitattributes.
I don't think it makes sense to operate on or take input from the
working tree of a remote; no other other command does, I don't think. I
had assumed, though, that .gitattributes files _in the tree being
exported_ would be used.
I thought there was some discussion of that a while ago (or possibly of
looking up .gitignore in the same way).
-Peff
next prev parent reply other threads:[~2008-03-31 2:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-27 3:08 .git/info/attributes not cloned Toby Corkindale
2008-03-27 3:33 ` Jeff King
2008-03-27 4:23 ` Toby Corkindale
2008-03-27 4:29 ` Jeff King
2008-03-27 4:48 ` Toby Corkindale
2008-03-27 4:53 ` Jeff King
2008-03-28 5:10 ` [BUG?] git-archive ignores remote .gitattributes (was: .git/info/attributes not cloned) Toby Corkindale
2008-03-28 12:22 ` Johannes Schindelin
2008-03-28 13:02 ` Jakub Narebski
2008-03-28 13:22 ` Johannes Schindelin
2008-03-31 2:47 ` Jeff King [this message]
2008-03-31 3:07 ` [BUG?] git-archive ignores remote .gitattributes Junio C Hamano
2008-04-10 4:14 ` Toby Corkindale
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080331024755.GA690@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=toby.corkindale@rea-group.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).