From: Christian Couder <chriscool@tuxfamily.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/3] diff-index: careful when inspecting work tree items
Date: Mon, 31 Mar 2008 05:47:15 +0200 [thread overview]
Message-ID: <200803310547.16053.chriscool@tuxfamily.org> (raw)
In-Reply-To: <7v7ifjsi2h.fsf@gitster.siamese.dyndns.org>
Le lundi 31 mars 2008, Junio C Hamano a écrit :
> Junio C Hamano <gitster@pobox.com> writes:
> > diff --git a/diff-lib.c b/diff-lib.c
> > index 52dbac3..a8e107a 100644
> > --- a/diff-lib.c
> > +++ b/diff-lib.c
> > ...
> > @@ -489,8 +516,11 @@ static int get_stat_data(struct cache_entry *ce,
> > if (!cached) {
> > int changed;
> > struct stat st;
> > - if (lstat(ce->name, &st) < 0) {
> > - if (errno == ENOENT && match_missing) {
> > + changed = check_work_tree_entity(ce, &st, NULL);
>
> This "NULL" should be "cbdata->symcache".
Tested-by: Christian Couder <chriscool@tuxfamily.org>
Your patch series works fine for me.
Thanks,
Christian.
next prev parent reply other threads:[~2008-03-31 3:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-29 7:13 Possible d/f conflict bug or regression Christian Couder
2008-03-29 8:01 ` Christian Couder
2008-03-30 1:29 ` Bryan Donlan
2008-03-30 4:44 ` Christian Couder
2008-03-30 4:51 ` Bryan Donlan
2008-03-30 23:46 ` Junio C Hamano
2008-03-31 0:28 ` [PATCH 1/3] Add corner case tests for diff-index and diff-files Junio C Hamano
2008-03-31 0:29 ` [PATCH 2/3] diff-index: careful when inspecting work tree items Junio C Hamano
2008-03-31 3:12 ` Junio C Hamano
2008-03-31 3:47 ` Christian Couder [this message]
2008-03-31 0:30 ` [PATCH 3/3] diff-files: " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803310547.16053.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).