From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Wong Subject: Re: [PATCH] git-svn: remove redundant slashes from show-ignore Date: Sun, 30 Mar 2008 23:26:37 -0700 Message-ID: <20080331062637.GA3082@hand.yhbt.net> References: <20080329233717.GA16157@soma> <1206834466.6543.30.camel@brick> <20080330013600.GB16157@soma> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Harvey Harrison , git@vger.kernel.org To: Junio C Hamano X-From: git-owner@vger.kernel.org Mon Mar 31 08:27:22 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1JgDUI-0006iN-C8 for gcvg-git-2@gmane.org; Mon, 31 Mar 2008 08:27:22 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752627AbYCaG0k (ORCPT ); Mon, 31 Mar 2008 02:26:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752591AbYCaG0k (ORCPT ); Mon, 31 Mar 2008 02:26:40 -0400 Received: from hand.yhbt.net ([66.150.188.102]:41396 "EHLO hand.yhbt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752459AbYCaG0j (ORCPT ); Mon, 31 Mar 2008 02:26:39 -0400 Received: from localhost.localdomain (localhost [127.0.0.1]) by hand.yhbt.net (Postfix) with ESMTP id 2D13E7F41D5; Sun, 30 Mar 2008 23:26:38 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20080330013600.GB16157@soma> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Eric Wong wrote: > Harvey Harrison wrote: > > On Sat, 2008-03-29 at 16:37 -0700, Eric Wong wrote: > > > Jonathan Scott Duff wrote: > > > > Recently I tried "git svn showignore" on my parrot repository and it > > > > failed. I tracked it down to the prop_walk() sub. When it recurses, > > > > $path has an extra / on the beginning (i.e., when it recurses, it > > > > tries to get the props for "//apps" instead of "/apps"). I *think* > > > > this is because $path is used in the recursive call rather than $p > > > > (which seems to contain a properly transformed $path). Anyway, I've > > > > attached a patch that works for me and I think is generally the right > > > > thing. > > > > > > Patch-submitted-by: Jonathan Scott Duff > > > > Shouldn't that be Signed-off-by? > > I'm not sure what the proper protocol for this should be, > as Jonathan emailed the patch to me privately without a sign-off... > > [1] - Out of respect for his privacy, I'm only Bcc-ing him to avoid > putting his address on the list. Signed-off-by: Jonathan Scott Duff Jonathan Scott Duff wrote: > Er ... yeah. I've very new to git (long time svn user though) so I don't > know what the cultural norms are here. So if I need to "sign off" on the > patch, consider it signed off :-) -- Eric Wong