From: Jeff King <peff@peff.net>
To: Jonathan del Strother <maillist@steelskies.com>
Cc: David Aguilar <davvid@gmail.com>, Git Mailing List <git@vger.kernel.org>
Subject: Re: Sending patches via gmail
Date: Tue, 1 Apr 2008 07:03:55 -0400 [thread overview]
Message-ID: <20080401110355.GA3777@coredump.intra.peff.net> (raw)
In-Reply-To: <57518fd10804010351x341ba728i69cfcad8f3909d6a@mail.gmail.com>
On Tue, Apr 01, 2008 at 11:51:38AM +0100, Jonathan del Strother wrote:
> ...which seems to work ok, except for the fact that the From line in
> my patch (the output of git format-patch) then appears at the top of
> my message body in the resulting email (from git send-email).
> Deleting the From line from the patch seems to make everything work as
> expected. Any ideas what's going on there?
send-email will create a "from" line in the body of the message if the
"sender" (using --from, or answering "Who should the emails appear to be
from") doesn't match the patch's author (the "From:" line in the
generated patch, which comes from the author field of the commit).
The line is interpeted by git-am to properly credit the original author.
It looks like you are committing as jon.delStrother@bestbefore.tv,
but sending the emails as maillist@steelskies.com.
-Peff
prev parent reply other threads:[~2008-04-01 11:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-01 9:49 Sending patches via gmail Jonathan del Strother
2008-04-01 10:09 ` David Aguilar
2008-04-01 10:51 ` Jonathan del Strother
2008-04-01 11:03 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080401110355.GA3777@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=maillist@steelskies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).